Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Side by Side Diff: chrome/BUILD.gn

Issue 2054893002: [Mac/GN] Add targets to run dump_syms and create the dSYM archive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 ":chrome_app", 428 ":chrome_app",
429 ] 429 ]
430 430
431 data_deps = [ 431 data_deps = [
432 ":chrome_app", 432 ":chrome_app",
433 ] 433 ]
434 434
435 if (debug_devtools) { 435 if (debug_devtools) {
436 deps += [ ":devtools_debug_resources" ] 436 deps += [ ":devtools_debug_resources" ]
437 } 437 }
438
439 if (is_chrome_branded && is_official_build) {
Mark Mentovai 2016/06/09 18:48:04 We don’t have a better variable for “want dumped s
Robert Sesek 2016/06/09 20:53:46 This is making the top-level "chrome" target depen
440 deps += [
441 ":chrome_dsym_archive",
442 ":chrome_dump_syms",
443 ]
444 }
438 } 445 }
439 446
440 tweak_info_plist("chrome_app_plist") { 447 tweak_info_plist("chrome_app_plist") {
441 info_plist = "app/app-Info.plist" 448 info_plist = "app/app-Info.plist"
442 _keystone_arg = "0" 449 _keystone_arg = "0"
443 if (enable_mac_keystone) { 450 if (enable_mac_keystone) {
444 _keystone_arg = "1" 451 _keystone_arg = "1"
445 } 452 }
446 args = [ 453 args = [
447 "--breakpad=0", 454 "--breakpad=0",
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 ":chrome_framework", 1004 ":chrome_framework",
998 ] 1005 ]
999 } 1006 }
1000 } else { 1007 } else {
1001 group("verify_chrome_framework_order") { 1008 group("verify_chrome_framework_order") {
1002 public_deps = [ 1009 public_deps = [
1003 ":chrome_framework", 1010 ":chrome_framework",
1004 ] 1011 ]
1005 } 1012 }
1006 } 1013 }
1014
1015 if (enable_dsyms) {
1016 # This list must be updated with the two targets' deps list below, and
1017 # the list of _dsyms in :chrome_dsym_archive.
1018 _chrome_symbols_sources = [
1019 "$root_out_dir/$chrome_framework_name.framework/$chrome_framework_name",
1020 "$root_out_dir/$chrome_helper_name.app/Contents/MacOS/$chrome_helper_name" ,
1021 "$root_out_dir/$chrome_product_full_name.app/Contents/MacOS/$chrome_produc t_full_name",
1022 "$root_out_dir/crashpad_handler",
1023 ]
1024
1025 # It is possible to run dump_syms on unstripped products without dSYMs,
1026 # but doing so isn't logical and won't happen in practice.
1027 action_foreach("chrome_dump_syms") {
1028 script = "//build/redirect_stdout.py"
1029
1030 sources = _chrome_symbols_sources
1031
1032 outputs = [
1033 "$root_out_dir/{{source_file_part}}-$chrome_version_full.breakpad",
1034 ]
1035
1036 # Prefix dump_syms with a ./ in case a user has it in their path.
Mark Mentovai 2016/06/09 18:48:04 Does this mean that gn or something puts an implic
Robert Sesek 2016/06/09 20:53:46 No, the way I had rebase_path'd it, there was no p
1037 args = rebase_path(outputs, root_out_dir) + [
1038 "./" + rebase_path("$root_out_dir/dump_syms", root_build_dir),
1039 "-g",
1040 rebase_path(
1041 "$root_out_dir/{{source_name_part}}.dSYM/Contents/Resources/D WARF/{{source_name_part}}",
1042 root_out_dir),
1043 "{{source}}",
1044 ]
1045
1046 deps = [
1047 ":chrome_app",
1048 ":chrome_framework",
1049 ":chrome_helper_app",
1050 "//breakpad:dump_syms",
1051 "//third_party/crashpad/crashpad/handler:crashpad_handler",
1052 ]
1053 }
1054
1055 action("chrome_dsym_archive") {
1056 script = "//chrome/tools/build/mac/archive_symbols.py"
1057
1058 # These are the dSYMs that will be archived. The sources list must be
1059 # are the target outputs that correspond to the dSYMs (since a dSYM is
1060 # a directory it cannot be listed as a source file). The targets that
1061 # generate both the dSYM and binary image are listed in deps.
1062 _dsyms = [
1063 "$root_out_dir/$chrome_framework_name.dSYM",
1064 "$root_out_dir/$chrome_helper_name.dSYM",
1065 "$root_out_dir/$chrome_product_full_name.dSYM",
1066 "$root_out_dir/crashpad_handler.dSYM",
1067 ]
1068
1069 sources = _chrome_symbols_sources
1070
1071 _output = "$root_out_dir/$chrome_product_full_name.dSYM.tar.bz2"
1072
1073 outputs = [
1074 _output,
1075 ]
1076
1077 args = [ rebase_path(_output, root_out_dir) ] +
1078 rebase_path(_dsyms, root_out_dir)
1079
1080 deps = [
1081 ":chrome_app",
1082 ":chrome_framework",
1083 ":chrome_helper_app",
1084 "//third_party/crashpad/crashpad/handler:crashpad_handler",
1085 ]
1086 }
1087 } else {
1088 group("chrome_dump_syms") {
1089 }
1090 group("chrome_symbol_archive") {
1091 }
1092 }
1007 } 1093 }
1008 1094
1009 # GYP version: chromium_browser_dependencies variable in chrome.gyp 1095 # GYP version: chromium_browser_dependencies variable in chrome.gyp
1010 group("browser_dependencies") { 1096 group("browser_dependencies") {
1011 public_deps = [ 1097 public_deps = [
1012 "//chrome/browser", 1098 "//chrome/browser",
1013 "//chrome/common", 1099 "//chrome/common",
1014 "//sync", 1100 "//sync",
1015 ] 1101 ]
1016 if (enable_plugins) { 1102 if (enable_plugins) {
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
1667 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1753 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1668 "//chrome/tools/build/linux/chrome-wrapper", 1754 "//chrome/tools/build/linux/chrome-wrapper",
1669 "//third_party/xdg-utils/scripts/xdg-mime", 1755 "//third_party/xdg-utils/scripts/xdg-mime",
1670 "//third_party/xdg-utils/scripts/xdg-settings", 1756 "//third_party/xdg-utils/scripts/xdg-settings",
1671 ] 1757 ]
1672 outputs = [ 1758 outputs = [
1673 "$root_out_dir/{{source_file_part}}", 1759 "$root_out_dir/{{source_file_part}}",
1674 ] 1760 ]
1675 } 1761 }
1676 } 1762 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698