Fix arguments object stubs for large arrays.

src/x64/code-stubs-x64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_X64
 
 #include "src/code-stubs.h"
 #include "src/api-arguments.h"
 #include "src/bootstrapper.h"
 #include "src/codegen.h"
@@ skipping 4450 matching lines @@
   }
 
   __ bind(&rest_parameters);
   {
     // Compute the pointer to the first rest parameter (skippping the receiver).
     __ leap(rbx, Operand(rbx, rax, times_pointer_size,
                          StandardFrameConstants::kCallerSPOffset -
                              1 * kPointerSize));
 
     // ----------- S t a t e -------------
+    //  -- rdi    : function
     //  -- rsi    : context
     //  -- rax    : number of rest parameters
     //  -- rbx    : pointer to first rest parameters
     //  -- rsp[0] : return address
     // -----------------------------------
 
     // Allocate space for the rest parameter array plus the backing store.
     Label allocate, done_allocate;
     __ leal(rcx, Operand(rax, times_pointer_size,
                          JSArray::kSize + FixedArray::kHeaderSize));
-    __ Allocate(rcx, rdx, rdi, no_reg, &allocate, NO_ALLOCATION_FLAGS);
+    __ Allocate(rcx, rdx, r8, no_reg, &allocate, NO_ALLOCATION_FLAGS);
     __ bind(&done_allocate);
 
     // Compute the arguments.length in rdi.
     __ Integer32ToSmi(rdi, rax);
 
     // Setup the elements array in rdx.
     __ LoadRoot(rcx, Heap::kFixedArrayMapRootIndex);
     __ movp(FieldOperand(rdx, FixedArray::kMapOffset), rcx);
     __ movp(FieldOperand(rdx, FixedArray::kLengthOffset), rdi);
     {
@@ skipping 17 matching lines @@
             Operand(rdx, rax, times_pointer_size, FixedArray::kHeaderSize));
     __ LoadNativeContextSlot(Context::JS_ARRAY_FAST_ELEMENTS_MAP_INDEX, rcx);
     __ movp(FieldOperand(rax, JSArray::kMapOffset), rcx);
     __ LoadRoot(rcx, Heap::kEmptyFixedArrayRootIndex);
     __ movp(FieldOperand(rax, JSArray::kPropertiesOffset), rcx);
     __ movp(FieldOperand(rax, JSArray::kElementsOffset), rdx);
     __ movp(FieldOperand(rax, JSArray::kLengthOffset), rdi);
     STATIC_ASSERT(JSArray::kSize == 4 * kPointerSize);
     __ Ret();
 
-    // Fall back to %AllocateInNewSpace.
+    // Fall back to %AllocateInNewSpace (if not too big).
+    Label too_big_for_new_space;
     __ bind(&allocate);
+    __ cmpl(rcx, Immediate(Page::kMaxRegularHeapObjectSize));
+    __ j(greater, &too_big_for_new_space);
     {
       FrameScope scope(masm, StackFrame::INTERNAL);
       __ Integer32ToSmi(rax, rax);
       __ Integer32ToSmi(rcx, rcx);
       __ Push(rax);
       __ Push(rbx);
       __ Push(rcx);
       __ CallRuntime(Runtime::kAllocateInNewSpace);
       __ movp(rdx, rax);
       __ Pop(rbx);
       __ Pop(rax);
       __ SmiToInteger32(rax, rax);
     }
     __ jmp(&done_allocate);
+
+    // Fall back to %NewRestParameter.
+    __ bind(&too_big_for_new_space);
+    __ PopReturnAddressTo(kScratchRegister);
+    __ Push(rdi);
+    __ PushReturnAddressFrom(kScratchRegister);
+    __ TailCallRuntime(Runtime::kNewRestParameter);
   }
 }
 
 
 void FastNewSloppyArgumentsStub::Generate(MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- rdi    : function
   //  -- rsi    : context
   //  -- rbp    : frame pointer
   //  -- rsp[0] : return address
@@ skipping 270 matching lines @@
         rax, Operand(rbx, ArgumentsAdaptorFrameConstants::kLengthOffset));
     __ leap(rbx, Operand(rbx, rax, times_pointer_size,
                          StandardFrameConstants::kCallerSPOffset -
                              1 * kPointerSize));
   }
   __ bind(&arguments_done);
 
   // ----------- S t a t e -------------
   //  -- rax    : number of arguments
   //  -- rbx    : pointer to the first argument
+  //  -- rdi    : function
   //  -- rsi    : context
   //  -- rsp[0] : return address
   // -----------------------------------
 
   // Allocate space for the strict arguments object plus the backing store.
   Label allocate, done_allocate;
   __ leal(rcx, Operand(rax, times_pointer_size, JSStrictArgumentsObject::kSize +
                                                     FixedArray::kHeaderSize));
-  __ Allocate(rcx, rdx, rdi, no_reg, &allocate, NO_ALLOCATION_FLAGS);
+  __ Allocate(rcx, rdx, r8, no_reg, &allocate, NO_ALLOCATION_FLAGS);
   __ bind(&done_allocate);
 
   // Compute the arguments.length in rdi.
   __ Integer32ToSmi(rdi, rax);
 
   // Setup the elements array in rdx.
   __ LoadRoot(rcx, Heap::kFixedArrayMapRootIndex);
   __ movp(FieldOperand(rdx, FixedArray::kMapOffset), rcx);
   __ movp(FieldOperand(rdx, FixedArray::kLengthOffset), rdi);
   {
@@ skipping 17 matching lines @@
           Operand(rdx, rax, times_pointer_size, FixedArray::kHeaderSize));
   __ LoadNativeContextSlot(Context::STRICT_ARGUMENTS_MAP_INDEX, rcx);
   __ movp(FieldOperand(rax, JSStrictArgumentsObject::kMapOffset), rcx);
   __ LoadRoot(rcx, Heap::kEmptyFixedArrayRootIndex);
   __ movp(FieldOperand(rax, JSStrictArgumentsObject::kPropertiesOffset), rcx);
   __ movp(FieldOperand(rax, JSStrictArgumentsObject::kElementsOffset), rdx);
   __ movp(FieldOperand(rax, JSStrictArgumentsObject::kLengthOffset), rdi);
   STATIC_ASSERT(JSStrictArgumentsObject::kSize == 4 * kPointerSize);
   __ Ret();
 
-  // Fall back to %AllocateInNewSpace.
+  // Fall back to %AllocateInNewSpace (if not too big).
+  Label too_big_for_new_space;
   __ bind(&allocate);
+  __ cmpl(rcx, Immediate(Page::kMaxRegularHeapObjectSize));
+  __ j(greater, &too_big_for_new_space);
   {
     FrameScope scope(masm, StackFrame::INTERNAL);
     __ Integer32ToSmi(rax, rax);
     __ Integer32ToSmi(rcx, rcx);
     __ Push(rax);
     __ Push(rbx);
     __ Push(rcx);
     __ CallRuntime(Runtime::kAllocateInNewSpace);
     __ movp(rdx, rax);
     __ Pop(rbx);
     __ Pop(rax);
     __ SmiToInteger32(rax, rax);
   }
   __ jmp(&done_allocate);
+
+  // Fall back to %NewStrictArguments.
+  __ bind(&too_big_for_new_space);
+  __ PopReturnAddressTo(kScratchRegister);
+  __ Push(rdi);
+  __ PushReturnAddressFrom(kScratchRegister);
+  __ TailCallRuntime(Runtime::kNewStrictArguments);
 }
 
 
 void LoadGlobalViaContextStub::Generate(MacroAssembler* masm) {
   Register context_reg = rsi;
   Register slot_reg = rbx;
   Register result_reg = rax;
   Label slow_case;
 
   // Go up context chain to the script context.
@@ skipping 528 matching lines @@
                            kStackUnwindSpace, nullptr, return_value_operand,
                            NULL);
 }
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_X64