Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2054853002: Fix arguments object stubs for large arrays. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix arguments object stubs for large arrays. This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-614727 BUG=chromium:614727 Committed: https://crrev.com/e95cfafb67dba67eb7c541d97f5e69f8280df771 Cr-Commit-Position: refs/heads/master@{#36917}

Patch Set 1 #

Patch Set 2 : Add missing frame state. #

Patch Set 3 : Extend to rest arguments. #

Patch Set 4 : Port to most architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -79 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 7 chunks +34 lines, -16 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 6 chunks +35 lines, -17 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 chunks +40 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 6 chunks +36 lines, -18 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 6 chunks +36 lines, -18 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 8 chunks +26 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-614727.js View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
Ports are still missing.
4 years, 6 months ago (2016-06-09 15:45:31 UTC) #1
Benedikt Meurer
Looks good. The idea of FastNewStrictArgumentsStub is that we don't always have to have a ...
4 years, 6 months ago (2016-06-09 17:22:03 UTC) #2
Michael Starzinger
Ports done. Also extended to rest parameters. PTAL.
4 years, 6 months ago (2016-06-10 13:22:54 UTC) #3
Benedikt Meurer
Thanks, LGTM.
4 years, 6 months ago (2016-06-10 17:21:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054853002/60001
4 years, 6 months ago (2016-06-13 07:53:23 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-13 08:23:00 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 08:25:55 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e95cfafb67dba67eb7c541d97f5e69f8280df771
Cr-Commit-Position: refs/heads/master@{#36917}

Powered by Google App Engine
This is Rietveld 408576698