Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2054843002: Revert of Flip Linux bots on chromium.lkgr to GN. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_memory_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) Reason for revert: This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. Original issue's description: > Flip Linux bots on chromium.lkgr to GN. > > R=brettw@chromium.org, inferno@chromium.org > BUG=605732 > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > Cr-Commit-Position: refs/heads/master@{#398038} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206 Cr-Commit-Position: refs/heads/master@{#398904}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : better rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M tools/mb/mb_config.pyl View 1 2 5 chunks +36 lines, -36 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Nico
Created Revert of Flip Linux bots on chromium.lkgr to GN.
4 years, 6 months ago (2016-06-09 15:05:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054843002/1
4 years, 6 months ago (2016-06-09 15:05:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/18717) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-09 15:07:47 UTC) #5
inferno
lgtm. Any idea why ASAN release bots were working fine, they also use chromium_builder_asan target.
4 years, 6 months ago (2016-06-09 15:10:11 UTC) #6
Nico
On 2016/06/09 15:10:11, inferno wrote: > lgtm. > > Any idea why ASAN release bots ...
4 years, 6 months ago (2016-06-09 15:16:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054843002/60001
4 years, 6 months ago (2016-06-09 15:22:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-09 16:29:30 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 16:29:57 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/424b728048335ebf880781b600f65fc7d993e206 Cr-Commit-Position: refs/heads/master@{#398904}
4 years, 6 months ago (2016-06-09 16:31:49 UTC) #18
Dirk Pranke
lgtm also, thanks for catching this :(. Though, I'm puzzled that this would've had no ...
4 years, 6 months ago (2016-06-09 16:39:52 UTC) #19
Nico
4 years, 6 months ago (2016-06-10 19:08:20 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2057193003/ by thakis@chromium.org.

The reason for reverting is: This might work now (see https://crbug.com/618702,
which I forgot to mention in the revert message)..

Powered by Google App Engine
This is Rietveld 408576698