|
|
Chromium Code Reviews
DescriptionRevert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
Reason for revert:
This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
Original issue's description:
> Flip Linux bots on chromium.lkgr to GN.
>
> R=brettw@chromium.org, inferno@chromium.org
> BUG=605732
>
> Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> Cr-Commit-Position: refs/heads/master@{#398038}
TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605732
Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
Cr-Commit-Position: refs/heads/master@{#398904}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : better rebase #Messages
Total messages: 20 (9 generated)
The CQ bit was checked by thakis@chromium.org
Created Revert of Flip Linux bots on chromium.lkgr to GN.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
lgtm. Any idea why ASAN release bots were working fine, they also use chromium_builder_asan target.
On 2016/06/09 15:10:11, inferno wrote: > lgtm. > > Any idea why ASAN release bots were working fine, they also use > chromium_builder_asan target. Yes: They're not on recipes yet, so gn still writes to out/None there and the gyp-built ninja files are used.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from inferno@chromium.org Link to the patchset: https://codereview.chromium.org/2054843002/#ps40001 (title: "rebase")
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from inferno@chromium.org Link to the patchset: https://codereview.chromium.org/2054843002/#ps60001 (title: "better rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054843002/60001
Message was sent while issue was closed.
Description was changed from ========== Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) Reason for revert: This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. Original issue's description: > Flip Linux bots on chromium.lkgr to GN. > > R=brettw@chromium.org, inferno@chromium.org > BUG=605732 > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > Cr-Commit-Position: refs/heads/master@{#398038} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 ========== to ========== Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) Reason for revert: This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. Original issue's description: > Flip Linux bots on chromium.lkgr to GN. > > R=brettw@chromium.org, inferno@chromium.org > BUG=605732 > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > Cr-Commit-Position: refs/heads/master@{#398038} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) Reason for revert: This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. Original issue's description: > Flip Linux bots on chromium.lkgr to GN. > > R=brettw@chromium.org, inferno@chromium.org > BUG=605732 > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > Cr-Commit-Position: refs/heads/master@{#398038} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 ========== to ========== Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) Reason for revert: This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. Original issue's description: > Flip Linux bots on chromium.lkgr to GN. > > R=brettw@chromium.org, inferno@chromium.org > BUG=605732 > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > Cr-Commit-Position: refs/heads/master@{#398038} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206 Cr-Commit-Position: refs/heads/master@{#398904} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/424b728048335ebf880781b600f65fc7d993e206 Cr-Commit-Position: refs/heads/master@{#398904}
Message was sent while issue was closed.
lgtm also, thanks for catching this :(. Though, I'm puzzled that this would've had no effect, as I used the same mechanism we use on the official builders (which are also not on recipes). I will investigate further.
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2057193003/ by thakis@chromium.org. The reason for reverting is: This might work now (see https://crbug.com/618702, which I forgot to mention in the revert message).. |
