Fix library private key stability during reload

Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload context an opportunity to provide a private key from the original library.
- [x] In identity reload mode, ensure that we pair all libraries as well as classes.

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/0e286e2fdd946338f16c42f449401b3dc50914a1

[Cutch, 2016-06-09 14:59:53]

Description was changed from

==========
Fix library private key stability during reload

BUG=
==========

to

==========
Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload
context an opportunity to a private key.
- [x] In identity reload mode, ensure that we pair all libraries as well as
classes.
==========

[Cutch, 2016-06-09 14:59:53]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[Cutch, 2016-06-09 15:00:36]

Description was changed from

==========
Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload
context an opportunity to a private key.
- [x] In identity reload mode, ensure that we pair all libraries as well as
classes.
==========

to

==========
Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload
context an opportunity to provide a private key from the original library.
- [x] In identity reload mode, ensure that we pair all libraries as well as
classes.
==========

[turnidge, 2016-06-10 18:13:26]

lgtm, but we should probably add a unit test for this case.

[Cutch, 2016-06-13 19:42:21]

Description was changed from

==========
Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload
context an opportunity to provide a private key from the original library.
- [x] In identity reload mode, ensure that we pair all libraries as well as
classes.
==========

to

==========
Fix library private key stability during reload

- [x] When allocating a library private key during reload, give the reload
context an opportunity to provide a private key from the original library.
- [x] In identity reload mode, ensure that we pair all libraries as well as
classes.

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0e286e2fdd946338f16c42f449401b3dc50914a1
==========

[Cutch, 2016-06-13 19:42:23]

Committed patchset #1 (id:1) manually as
0e286e2fdd946338f16c42f449401b3dc50914a1 (presubmit successful).

[Cutch, 2016-06-13 19:45:27]

On 2016/06/10 18:13:26, turnidge wrote:
> lgtm, but we should probably add a unit test for this case.

I agree but a unit test is difficult to write without adding a flag which forces
this behaviour to occur.

[siva, 2016-06-13 19:49:55]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-06-13 19:49:56]

https://codereview.chromium.org/2054833002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2054833002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:10561: StorePointer(&raw_ptr()->private_key_,
original_key.raw());
How do you ensure that there is no collision between the original_key and any
new key that is computed for say a new library that got added as part of the
reload?

[Cutch, 2016-06-13 19:55:38]

https://codereview.chromium.org/2054833002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2054833002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:10561: StorePointer(&raw_ptr()->private_key_,
original_key.raw());
On 2016/06/13 19:49:56, siva wrote:
> How do you ensure that there is no collision between the original_key and any
> new key that is computed for say a new library that got added as part of the
> reload?

Presently we don't. I wonder if we should go back to the old way of assigning
library private keys when reloading?