third_party/WebKit/Source/modules/payments/PaymentResponse.cpp - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentResponse.h ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

index e79a75d89936ed83bccd849646cf6cf296640e25..a2e498f4a546acc24119d918c351715a5f3a5197 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

@@ -47,9 +47,14 @@ ScriptValue PaymentResponse::details(ScriptState* scriptState, ExceptionState& e

return ScriptValue(scriptState, fromJSONString(scriptState, m_stringifiedDetails, exceptionState));

}

-ScriptPromise PaymentResponse::complete(ScriptState* scriptState, bool success)

+ScriptPromise PaymentResponse::complete(ScriptState* scriptState, const String& result)

{

- return m_paymentCompleter->complete(scriptState, success);

+ PaymentComplete convertedResult = Unknown;

+ if (result == "success")

+ convertedResult = Success;

+ if (result == "fail")

+ convertedResult = Fail;

+ return m_paymentCompleter->complete(scriptState, convertedResult);

}

DEFINE_TRACE(PaymentResponse)