Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3886)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index 07be71b7c286f919ddffa3d240958f6bc3d70d57..99ee7827d1abcc06177a8d8629ab575fffecad0f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -396,12 +396,12 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
*
* Should not be called multiple times.
*
- * @param paymentSuccess Whether the payment (if any) was successful.
+ * @param result Whether the payment (if any) was successful.
* @param callback The callback to notify of finished animations.
*/
- public void close(boolean paymentSuccess, final Runnable callback) {
+ public void close(int result, final Runnable callback) {
please use gerrit instead 2016/06/10 19:15:35 Continue using a boolean.
mIsClientClosing = true;
- mResultView.update(paymentSuccess, new Runnable() {
+ mResultView.update(result, new Runnable() {
@Override
public void run() {
dismissDialog(false);

Powered by Google App Engine
This is Rietveld 408576698