third_party/WebKit/Source/modules/payments/PaymentResponse.idl - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.idl

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentResponse.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 // https://w3c.github.io/browser-payment-api/#idl-def-paymentcomplete

	6

	7 enum PaymentComplete {

	8 "success",

	9 "fail",

	10 ""

	11 };

	12

5 // https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentre sponse-interface	13 // https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentre sponse-interface

6	14

7 [	15 [

8 RuntimeEnabled=PaymentRequest,	16 RuntimeEnabled=PaymentRequest,

9 ] interface PaymentResponse {	17 ] interface PaymentResponse {

10 readonly attribute DOMString methodName;	18 readonly attribute DOMString methodName;

11 readonly attribute CurrencyAmount totalAmount;	19 readonly attribute CurrencyAmount totalAmount;

12 readonly attribute DOMString? payerEmail;	20 readonly attribute DOMString? payerEmail;

13 readonly attribute DOMString? payerPhone;	21 readonly attribute DOMString? payerPhone;

14 [CallWith=ScriptState, RaisesException] readonly attribute object details;	22 [CallWith=ScriptState, RaisesException] readonly attribute object details;

15 readonly attribute PaymentAddress? shippingAddress;	23 readonly attribute PaymentAddress? shippingAddress;

16	24

17 [CallWith=ScriptState] Promise<void> complete(boolean success);	25 [CallWith=ScriptState] Promise<void> complete(optional PaymentComplete payme ntResult = "");

18 };	26 };

OLD	NEW