[gn] Improve sharing common configuration

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
@@ skipping 33 matching lines @@
   # Enable slow dchecks.
   v8_enable_slow_dchecks = false
 
   # Interpreted regexp engine exists as platform-independent alternative
   # based where the regular expression is compiled to a bytecode.
   v8_interpreted_regexp = false
 
   # Sets -dOBJECT_PRINT.
   v8_object_print = false
 
-  # Turns on compiler optimizations in V8 in Debug build.
-  v8_optimized_debug = true
-
   # With post mortem support enabled, metadata is embedded into libv8 that
   # describes various parameters of the VM for use by debuggers. See
   # tools/gen-postmortem-metadata.py for details.
   v8_postmortem_support = false
 
   # Similar to vfp but on MIPS.
   v8_can_use_fpu_instructions = true
 
   # Similar to the ARM hard float ABI but on MIPS.
   v8_use_mips_abi_hardfloat = true
@@ skipping 229 matching lines @@
     ]
     if (v8_enable_slow_dchecks) {
       defines += [ "ENABLE_SLOW_DCHECKS" ]
     }
   } else if (dcheck_always_on) {
     defines += [ "DEBUG" ]
   }
 }
 
 ###############################################################################
-# Templates
-#
-
-template("v8_source_set") {
-  source_set(target_name) {
-    forward_variables_from(invoker, "*", [ "configs" ])
-    configs += invoker.configs
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    configs += [
-      ":features",
-      ":toolchain",
-    ]
-
-    # TODO(machenbach): This config doesn't affect executables and components.
-    # It should be moved to a common place.
-    if (is_debug && !v8_optimized_debug) {
-      configs -= [ "//build/config/compiler:default_optimization" ]
-      configs += [ "//build/config/compiler:no_optimize" ]
-    } else {
-      configs -= [ "//build/config/compiler:default_optimization" ]
-      configs += [ "//build/config/compiler:optimize_max" ]
-    }
-  }
-}
-
-###############################################################################
 # Actions
 #
 
 action("js2c") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
   # changes.
@@ skipping 1694 matching lines @@
   ]
 
   configs = [ ":internal_config_base" ]
 }
 
 ###############################################################################
 # Executables
 #
 
 if (current_toolchain == v8_snapshot_toolchain) {
-  executable("mksnapshot") {
+  v8_executable("mksnapshot") {
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
     sources = [
       "src/snapshot/mksnapshot.cc",
     ]
 
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    configs += [
+    configs = [
       ":internal_config",
-      ":features",
-      ":toolchain",
     ]
 
     deps = [
       ":v8_base",
       ":v8_libplatform",
       ":v8_nosnapshot",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
   }
@@ skipping 26 matching lines @@
   if (want_v8_shell) {
     deps += [ ":v8_shell" ]
   }
 
   if (v8_test_isolation_mode != "noop") {
     deps += [ ":d8_run" ]
   }
 }
 
 if (is_component_build) {
-  component("v8") {
+  v8_component("v8") {
     sources = [
       "src/v8dll-main.cc",
     ]
 
     public_deps = [
       ":v8_base",
       ":v8_maybe_snapshot",
     ]
 
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    configs += [
+    configs = [
       ":internal_config",
-      ":features",
-      ":toolchain",
     ]
 
     public_configs = [ ":external_config" ]
   }
 } else {
   group("v8") {
     public_deps = [
       ":v8_base",
       ":v8_maybe_snapshot",
     ]
     public_configs = [ ":external_config" ]
   }
 }
 
-executable("d8") {
+v8_executable("d8") {
   sources = [
     "src/d8.cc",
     "src/d8.h",
   ]
 
-  configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [ "//build/config/compiler:no_chromium_code" ]
-  configs += [
+  configs = [
     # Note: don't use :internal_config here because this target will get
     # the :external_config applied to it by virtue of depending on :v8, and
     # you can't have both applied to the same target.
     ":internal_config_base",
-    ":features",
-    ":toolchain",
   ]
 
   deps = [
     ":d8_js2c",
     ":v8",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
@@ skipping 15 matching lines @@
 
 v8_isolate_run("d8") {
   deps = [
     ":d8",
   ]
 
   isolate = "//src/d8.isolate"
 }
 
 if (want_v8_shell) {
-  executable("v8_shell") {
+  v8_executable("v8_shell") {
     sources = [
       "samples/shell.cc",
     ]
 
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    configs += [
+    configs = [
       # Note: don't use :internal_config here because this target will get
       # the :external_config applied to it by virtue of depending on :v8, and
       # you can't have both applied to the same target.
       ":internal_config_base",
-      ":features",
-      ":toolchain",
     ]
 
     deps = [
       ":v8",
       ":v8_libplatform",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
 
     if (v8_enable_i18n_support) {
       deps += [ "//third_party/icu" ]
     }
   }
 }
 
 template("v8_fuzzer") {
   name = target_name
   forward_variables_from(invoker, "*")
-  executable("v8_simple_" + name) {
+  v8_executable("v8_simple_" + name) {
     deps = [
       ":" + name,
       ":simple_fuzzer",
       "//build/win:default_exe_manifest",
     ]
 
-    configs += [ ":external_config" ]
+    configs = [ ":external_config" ]
   }
 }
 
 v8_source_set("json_fuzzer") {
   sources = [
     "test/fuzzer/json.cc",
   ]
 
   deps = [
     ":fuzzer_support",
@@ skipping 57 matching lines @@
 
   deps = [
     ":fuzzer_support",
   ]
 
   configs = [ ":internal_config" ]
 }
 
 v8_fuzzer("wasm_asmjs_fuzzer") {
 }