Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2054783002: ChromeVox access to login user pod menus (Closed)

Created:
4 years, 6 months ago by Greg Levin
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeVox access to login user pod menus BUG=536141 TEST=Turn on ChromeVox. On login user pods, TAB from password to menu button, press ENTER. CV should read name/email. Press TAB or SHIFT+TAB, observe that focus moves as expected. Committed: https://crrev.com/3ff2a29e435f5cbde34fe00d9e98fb88f5d43d19 Cr-Commit-Position: refs/heads/master@{#399753}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M ui/login/account_picker/user_pod_row.css View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 8 chunks +74 lines, -10 lines 2 comments Download

Messages

Total messages: 16 (6 generated)
Greg Levin
Please have a look! https://codereview.chromium.org/2054783002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2054783002/diff/1/ui/login/account_picker/user_pod_row.js#newcode938 ui/login/account_picker/user_pod_row.js:938: * @type {!HTMLDivElement} No idea ...
4 years, 6 months ago (2016-06-09 13:44:46 UTC) #2
achuithb
+Jake
4 years, 6 months ago (2016-06-09 20:41:52 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054783002/1
4 years, 6 months ago (2016-06-09 20:42:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 21:25:59 UTC) #8
jdufault
lgtm
4 years, 6 months ago (2016-06-09 21:48:12 UTC) #9
achuithb
lgtm
4 years, 6 months ago (2016-06-14 17:43:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054783002/1
4 years, 6 months ago (2016-06-14 17:44:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 18:26:23 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 18:26:38 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 18:27:51 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ff2a29e435f5cbde34fe00d9e98fb88f5d43d19
Cr-Commit-Position: refs/heads/master@{#399753}

Powered by Google App Engine
This is Rietveld 408576698