chrome/browser/extensions/pending_extension_manager.cc - Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pending_extension_manager.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to code review by treib@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_util.cc ('K') | « chrome/browser/extensions/pending_extension_manager.h ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/pending_extension_manager.cc

diff --git a/chrome/browser/extensions/pending_extension_manager.cc b/chrome/browser/extensions/pending_extension_manager.cc

index 632ea4da55f7e5687f2fb8b398e68e3b648b8cdf..36b53922ad54f684e0033118e2c698bedfc9a1ee 100644

--- a/chrome/browser/extensions/pending_extension_manager.cc

+++ b/chrome/browser/extensions/pending_extension_manager.cc

@@ -91,8 +91,7 @@ bool PendingExtensionManager::AddFromSync(

const GURL& update_url,

const base::Version& version,

PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install,

- bool remote_install,

- bool installed_by_custodian) {

+ bool remote_install) {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (ExtensionRegistry::Get(context_)->GetExtensionById(

@@ -111,9 +110,6 @@ bool PendingExtensionManager::AddFromSync(

}

int creation_flags = Extension::NO_FLAGS;

- if (installed_by_custodian) {

- creation_flags |= Extension::WAS_INSTALLED_BY_CUSTODIAN;

- }

static const bool kIsFromSync = true;

static const Manifest::Location kSyncLocation = Manifest::INTERNAL;