Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: chrome/browser/supervised_user/supervised_user_service_unittest.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reload if installed_by_custodian becomes false. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_service_unittest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_service_unittest.cc b/chrome/browser/supervised_user/supervised_user_service_unittest.cc
index 06e2dc2164a3641d4fd786842f8720a88617f305..180cb1fceabaf8f32f9c6269a32a043a6ea3498e 100644
--- a/chrome/browser/supervised_user/supervised_user_service_unittest.cc
+++ b/chrome/browser/supervised_user/supervised_user_service_unittest.cc
@@ -41,6 +41,7 @@
#if defined(ENABLE_EXTENSIONS)
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
+#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/unpacked_installer.h"
#include "chrome/common/extensions/features/feature_channel.h"
#include "extensions/common/extension.h"
@@ -407,14 +408,14 @@ class SupervisedUserServiceExtensionTestBase
.Set(extensions::manifest_keys::kName, "Extension")
.Set(extensions::manifest_keys::kVersion, "1.0")
.Build();
- int creation_flags = extensions::Extension::NO_FLAGS;
- if (by_custodian)
- creation_flags |= extensions::Extension::WAS_INSTALLED_BY_CUSTODIAN;
+
extensions::ExtensionBuilder builder;
scoped_refptr<extensions::Extension> extension =
builder.SetManifest(std::move(manifest))
- .AddFlags(creation_flags)
.Build();
+ extensions::util::SetWasInstalledByCustodian(extension->id(),
Marc Treib 2016/06/20 16:42:38 nit: misaligned
mamir 2016/06/20 16:55:45 Done.
+ profile_.get(), by_custodian);
+
return extension;
}

Powered by Google App Engine
This is Rietveld 408576698