chrome/browser/extensions/installed_loader.cc - Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to code review by Devlin Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_util.cc ('K') | « chrome/browser/extensions/extension_util.cc ('k') | chrome/browser/extensions/pending_extension_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/installed_loader.cc

diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc

index 197410b5c9b9e188108ab09c1c440e43e1b9a9df..96dd0b63fcf6f8f268c6a31bef7d2656cc8211f2 100644

--- a/chrome/browser/extensions/installed_loader.cc

+++ b/chrome/browser/extensions/installed_loader.cc

@@ -609,6 +609,12 @@ int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {

flags |= Extension::REQUIRE_KEY;

if (extension_prefs_->AllowFileAccess(info->extension_id))

flags |= Extension::ALLOW_FILE_ACCESS;

+ bool installed_by_custodian = util::WasInstalledByCustodian(

+ info->extension_id, extension_service_->profile());

Devlin 2016/06/15 00:30:36 is this git cl formatted?

mamir 2016/06/15 09:54:41 Yes.

+ if (installed_by_custodian)

+ flags |= Extension::WAS_INSTALLED_BY_CUSTODIAN;

return flags;

}