chrome/browser/extensions/extension_service.cc - Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to code review by Devlin Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 93c7c595a9608db4cb0025a10e1f7202aef4240b..99fc5e56dfbd90afbf5a72949c50dbd4d8cde890 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -548,7 +548,6 @@ bool ExtensionService::UpdateExtension(const extensions::CRXFileInfo& file,

installer->set_expected_version(expected_version,

false /* fail_install_if_unexpected */);

}

- creation_flags = pending_extension_info->creation_flags();

if (pending_extension_info->mark_acknowledged())

external_install_manager_->AcknowledgeExternalExtension(id);

} else if (extension) {

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_sync_unittest.cc » ('j') | chrome/browser/extensions/extension_util.cc » ('J')