Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

chrome/browser/extensions/extension_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_util.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/values.h"
@@ skipping 202 matching lines @@
   // Reload to update browser state. Only bother if the value changed and the
   // extension is actually enabled, since there is no UI otherwise.
   if (allow == AllowFileAccess(extension_id, context))
     return;
 
   ExtensionPrefs::Get(context)->SetAllowFileAccess(extension_id, allow);
 
   ReloadExtensionIfEnabled(extension_id, context);
 }
 
+void SetWasInstalledByCustodian(const std::string& extension_id,
+                                content::BrowserContext* context,
+                                bool installed_by_custodian) {
+  const Extension* extension =
+      ExtensionRegistry::Get(context)->GetInstalledExtension(extension_id);
+  if (extension &&

[Devlin, 2016/06/13 14:36:58]

mention how extension can be null.

[mamir, 2016/06/13 15:25:31]

Done.

+      installed_by_custodian == extension->was_installed_by_custodian())
+    return;
+  ExtensionPrefs::Get(context)->SetWasInstalledByCustodian(
+      extension_id, installed_by_custodian);
+  ExtensionService* service =
+      ExtensionSystem::Get(context)->extension_service();
+  // Since the was_installed_by_custodian is stored as a creation flag in the
+  // Extension immultable object, a reload is required.

[Marc Treib, 2016/06/13 14:36:50]

immutable

[mamir, 2016/06/13 15:25:31]

Done.

+  service->ReloadExtension(extension_id);
+}
+
 bool AllowedScriptingOnAllUrls(const std::string& extension_id,
                                content::BrowserContext* context) {
   bool allowed = false;
   ExtensionPrefs* prefs = ExtensionPrefs::Get(context);
   if (!prefs->ReadPrefAsBoolean(extension_id,
                                 kExtensionAllowedOnAllUrlsPrefName,
                                 &allowed)) {
     // If there is no value present, we make one, defaulting it to the value of
     // the 'scripts require action' flag. If the flag is on, then the extension
     // does not have permission to script on all urls by default.
@@ skipping 156 matching lines @@
   base::FieldTrialList::FindFullName(
       kSupervisedUserExtensionPermissionIncreaseFieldTrialName);
   std::string value = variations::GetVariationParamValue(
       kSupervisedUserExtensionPermissionIncreaseFieldTrialName,
       profile->IsChild() ? "child_account" : "legacy_supervised_user");
   return value == "true";
 }
 
 }  // namespace util
 }  // namespace extensions