chrome/browser/extensions/installed_loader.cc - Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/installed_loader.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to code review by treib@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_util.cc ('K') | « chrome/browser/extensions/extension_util.cc ('k') | chrome/browser/extensions/pending_extension_manager.h » ('j') | extensions/browser/extension_prefs.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/installed_loader.h"	5 #include "chrome/browser/extensions/installed_loader.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/files/file_path.h"	9 #include "base/files/file_path.h"

10 #include "base/metrics/histogram_macros.h"	10 #include "base/metrics/histogram_macros.h"

(...skipping 591 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
602 UMA_HISTOGRAM_COUNTS_100("Extensions.EventlessEventPages",	602 UMA_HISTOGRAM_COUNTS_100("Extensions.EventlessEventPages",

603 eventless_event_pages_count);	603 eventless_event_pages_count);

604 }	604 }

605	605

606 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {	606 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {

607 int flags = extension_prefs_->GetCreationFlags(info->extension_id);	607 int flags = extension_prefs_->GetCreationFlags(info->extension_id);

608 if (!Manifest::IsUnpackedLocation(info->extension_location))	608 if (!Manifest::IsUnpackedLocation(info->extension_location))

609 flags \|= Extension::REQUIRE_KEY;	609 flags \|= Extension::REQUIRE_KEY;

610 if (extension_prefs_->AllowFileAccess(info->extension_id))	610 if (extension_prefs_->AllowFileAccess(info->extension_id))

611 flags \|= Extension::ALLOW_FILE_ACCESS;	611 flags \|= Extension::ALLOW_FILE_ACCESS;

	612 if (extension_prefs_->WasInstalledByCustodian(info->extension_id))

	613 flags \|= Extension::WAS_INSTALLED_BY_CUSTODIAN;

612 return flags;	614 return flags;

613 }	615 }

614	616

615 } // namespace extensions	617 } // namespace extensions

OLD	NEW