Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

chrome/browser/extensions/extension_sync_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_sync_data.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 69 matching lines @@
       all_urls_enabled_(BOOLEAN_UNSET),
       installed_by_custodian_(false),
       launch_type_(LAUNCH_TYPE_INVALID) {
 }
 
 ExtensionSyncData::ExtensionSyncData(const Extension& extension,
                                      bool enabled,
                                      int disable_reasons,
                                      bool incognito_enabled,
                                      bool remote_install,
-                                     OptionalBoolean all_urls_enabled)
+                                     OptionalBoolean all_urls_enabled,
+                                     bool installed_by_custodian)
     : ExtensionSyncData(extension, enabled, disable_reasons, incognito_enabled,
-                        remote_install, all_urls_enabled, StringOrdinal(),
+                        remote_install, all_urls_enabled,
+                        installed_by_custodian, StringOrdinal(),
                         StringOrdinal(), LAUNCH_TYPE_INVALID) {
 }
 
 ExtensionSyncData::ExtensionSyncData(const Extension& extension,
                                      bool enabled,
                                      int disable_reasons,
                                      bool incognito_enabled,
                                      bool remote_install,
                                      OptionalBoolean all_urls_enabled,
+                                     bool installed_by_custodian,
                                      const StringOrdinal& app_launch_ordinal,
                                      const StringOrdinal& page_ordinal,
                                      extensions::LaunchType launch_type)
     : is_app_(extension.is_app()),
       id_(extension.id()),
       uninstalled_(false),
       enabled_(enabled),
       supports_disable_reasons_(true),
       disable_reasons_(disable_reasons),
       incognito_enabled_(incognito_enabled),
       remote_install_(remote_install),
       all_urls_enabled_(all_urls_enabled),
-      installed_by_custodian_(extension.was_installed_by_custodian()),
+      installed_by_custodian_(installed_by_custodian),
       version_(extension.from_bookmark() ? base::Version("0")
                                          : *extension.version()),
       update_url_(ManifestURL::GetUpdateURL(&extension)),
       name_(extension.non_localized_name()),
       app_launch_ordinal_(app_launch_ordinal),
       page_ordinal_(page_ordinal),
       launch_type_(launch_type) {
   if (is_app_ && extension.from_bookmark()) {
     bookmark_app_description_ = extension.description();
     bookmark_app_url_ = AppLaunchInfo::GetLaunchWebURL(&extension).spec();
@@ skipping 192 matching lines @@
 
   if (entity_specifics.has_extension())
     return PopulateFromExtensionSpecifics(entity_specifics.extension());
 
   LOG(ERROR) << "Attempt to sync bad EntitySpecifics: no extension data.";
   RecordBadSyncData(NO_EXTENSION_SPECIFICS);
   return false;
 }
 
 }  // namespace extensions