Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

extensions/common/extension.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_H_
 #define EXTENSIONS_COMMON_EXTENSION_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 135 matching lines @@
 
     // Unused - this flag has been moved to ExtensionPrefs.
     IS_EPHEMERAL = 1 << 9,
 
     // |WAS_INSTALLED_BY_OEM| installed by an OEM (e.g on Chrome OS) and should
     // be placed in a special OEM folder in the App Launcher. Note: OEM apps are
     // also installed by Default (i.e. WAS_INSTALLED_BY_DEFAULT is also true).
     WAS_INSTALLED_BY_OEM = 1 << 10,
 
     // |WAS_INSTALLED_BY_CUSTODIAN| means this extension was installed by the
     // custodian of a supervised user.

[Marc Treib, 2016/06/17 08:56:54]

I'd remove this comment now - if someone cares, they should look at the pref
instead. (This one is bound to get out of date)

[mamir, 2016/06/17 16:12:55]

Done.

-    WAS_INSTALLED_BY_CUSTODIAN = 1 << 11,
+    // DEPRECATED:: WAS_INSTALLED_BY_CUSTODIAN is now stored as a pref instead.
+    // WAS_INSTALLED_BY_CUSTODIAN= 1 << 11,
 
     // |MAY_BE_UNTRUSTED| indicates that this extension came from a potentially
     // unsafe source (e.g., sideloaded from a local CRX file via the Windows
     // registry). Such extensions may be subjected to additional constraints
     // before they are fully installed and enabled.
     MAY_BE_UNTRUSTED = 1 << 12,
 
     // When adding new flags, make sure to update kInitFromValueFlagBits.
   };
 
@@ skipping 156 matching lines @@
   bool from_bookmark() const { return (creation_flags_ & FROM_BOOKMARK) != 0; }
   bool may_be_untrusted() const {
     return (creation_flags_ & MAY_BE_UNTRUSTED) != 0;
   }
   bool was_installed_by_default() const {
     return (creation_flags_ & WAS_INSTALLED_BY_DEFAULT) != 0;
   }
   bool was_installed_by_oem() const {
     return (creation_flags_ & WAS_INSTALLED_BY_OEM) != 0;
   }
-  bool was_installed_by_custodian() const {
-    return (creation_flags_ & WAS_INSTALLED_BY_CUSTODIAN) != 0;
-  }
 
   // Type-related queries.
   bool is_app() const;
   bool is_platform_app() const;
   bool is_hosted_app() const;
   bool is_legacy_packaged_app() const;
   bool is_extension() const;
   bool is_shared_module() const;
   bool is_theme() const;
 
@@ skipping 219 matching lines @@
   const PermissionSet& permissions;
 
   UpdatedExtensionPermissionsInfo(const Extension* extension,
                                   const PermissionSet& permissions,
                                   Reason reason);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_H_