common/dirwalk/test.sh - Issue 2054763004: luci-go/common/dirwalk: Code for walking a directory tree efficiently

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: common/dirwalk/test.sh

Issue 2054763004: luci-go/common/dirwalk: Code for walking a directory tree efficiently Base URL: https://github.com/luci/luci-go@master

Patch Set: Small updates. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/bash
	M-A Ruel 2016/09/15 14:31:02 I'd like to have the test to be split up in a sepa I'd like to have the test to be split up in a separate CL, that could be committed first. It needs to be made to work on Windows, so I recommend writing this in Go too. It's not super efficient LoC-wise but it'll make the whole thing more maintainable. mithro 2016/09/20 12:41:44 This file is just to make it easy to run all the p Show quoted text On 2016/09/15 14:31:02, M-A Ruel wrote: > I'd like to have the test to be split up in a separate CL, that could be > committed first. It needs to be made to work on Windows, so I recommend writing > this in Go too. It's not super efficient LoC-wise but it'll make the whole thing > more maintainable. This file is just to make it easy to run all the performance tests at once (so I can step away for a coffee) -- I wouldn't expect to use if you wanted to run these tests continuously. Should I just remove the file? M-A Ruel 2016/09/20 16:37:27 Yes, we do not use bash unless it is expressively Show quoted text On 2016/09/20 12:41:44, mithro wrote: > On 2016/09/15 14:31:02, M-A Ruel wrote: > > I'd like to have the test to be split up in a separate CL, that could be > > committed first. It needs to be made to work on Windows, so I recommend > writing > > this in Go too. It's not super efficient LoC-wise but it'll make the whole > thing > > more maintainable. > > This file is just to make it easy to run all the performance tests at once (so I > can step away for a coffee) -- I wouldn't expect to use if you wanted to run > these tests continuously. > > Should I just remove the file? Yes, we do not use bash unless it is expressively posix specific. As I said, this has to be reimplemented in Go. I'm fine with the idea, just not the language.
	2 # Copyright 2016 The LUCI Authors. All rights reserved.

	3 # Use of this source code is governed under the Apache License, Version 2.0

	4 # that can be found in the LICENSE file.

	5

	6 TESTS=common/dirwalk/tests/*.json

	7

	8 go install github.com/luci/luci-go/common/dirwalk/tests/tools/gendir

	9 go install github.com/luci/luci-go/common/dirwalk/tests/tools/walkdir

	10

	11 echo "Generating the test directories"

	12 TMPDIR=/usr/local/google/tmp/luci-tests

	13 mkdir -p $TMPDIR

	14 for TESTFILE in $TESTS; do

	15 TESTNAME="$(basename $TESTFILE .json)"

	16 TESTDIR="$TMPDIR/$TESTNAME"

	17 if ! [ -d $TESTDIR ]; then

	18 echo "Generating test directory for $TESTNAME"

	19 gendir -config $TESTFILE -outdir $TESTDIR

	20 du -h $TESTDIR

	21 fi

	22 done

	23

	24 for METHOD in simple nostat parallel; do

	25 echo "Running $METHOD"

	26 for TESTFILE in $TESTS; do

	27 TESTNAME="$(basename $TESTFILE .json)"

	28 TESTDIR="$TMPDIR/$TESTNAME"

	29 OUTPUT=output.$METHOD.$TESTNAME

	30 echo "Running $METHOD.$TESTNAME"

	31 rm $OUTPUT

	32 $(which time) --verbose --output=$OUTPUT --append walkdir --dir $TESTDIR --method $METHOD $@ 2> $OUTPUT

	33 tail -n 20 $OUTPUT

	34 echo

	35 done

	36 echo

	37 echo

	38 echo

	39 done

OLD	NEW

« common/dirwalk/observer.go ('K') | « common/dirwalk/observer.go ('k') | common/dirwalk/tests/test1.json » ('j') | common/dirwalk/tests/test1.json » ('J')