Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2054723002: Spellchecking should not be cancelled if editing is done in between

Created:
4 years, 6 months ago by pals
Modified:
3 years, 8 months ago
Reviewers:
groby-ooo-7-16, rwlbuis
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Spellchecking should not be cancelled if editing is done in between existing content. Spell checking is done when space is entered. While there is "some text" after the caret position and there is no space after the whole text, spell checking is cancelled. Added an extra " " for spell checking to happen in all cases. BUG=610557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/renderer/spellchecker/spellcheck_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054723002/1
4 years, 6 months ago (2016-06-09 10:27:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/225996)
4 years, 6 months ago (2016-06-09 10:55:53 UTC) #4
pals
Please review the approach. If it is ok, I can modify the test expectations.
4 years, 6 months ago (2016-06-15 07:36:46 UTC) #7
please use gerrit instead
-rouslan@ +groby@
4 years, 6 months ago (2016-06-15 15:22:22 UTC) #10
groby-ooo-7-16
On 2016/06/15 15:22:22, Rouslan (ツ) wrote: > -rouslan@ > +groby@ I'd prefer it if we ...
4 years, 6 months ago (2016-06-15 18:28:08 UTC) #11
pals
On 2016/06/15 18:28:08, groby wrote: > On 2016/06/15 15:22:22, Rouslan (ツ) wrote: > > -rouslan@ ...
4 years, 6 months ago (2016-06-16 03:41:55 UTC) #12
groby-ooo-7-16
On 2016/06/16 03:41:55, pals wrote: > On 2016/06/15 18:28:08, groby wrote: > > On 2016/06/15 ...
4 years, 6 months ago (2016-06-21 02:38:50 UTC) #14
rwlbuis
3 years, 8 months ago (2017-04-13 20:50:37 UTC) #16
Sanjoy, it seems the bug is fixed, is this patch still needed?

Powered by Google App Engine
This is Rietveld 408576698