third_party/WebKit/Source/core/fetch/ImageResource.h - Issue 2054643003: Remove duplication of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 2054643003: Remove duplication of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.h b/third_party/WebKit/Source/core/fetch/ImageResource.h

index da0995f2be6bd16bcc3322560240f8f7a1f3528b..7f4228a15c2b1bcd269daeae53d86eb6f12b1297 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.h

@@ -99,6 +99,7 @@ public:

void allClientsAndObserversRemoved() override;

+ PassRefPtr<SharedBuffer> resourceBuffer() const override;

void appendData(const char*, size_t) override;

void error(const ResourceError&) override;

void responseReceived(const ResourceResponse&, std::unique_ptr<WebDataConsumerHandle>) override;

@@ -153,8 +154,6 @@ private:

void createImage();

void updateImage(bool allDataReceived);

- void updateImageAndClearBuffer();

- void clearImage();

// If not null, changeRect is the changed part of the image.

void notifyObservers(const IntRect* changeRect = nullptr);