Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 205463002: Setting HTMLStyleElement should use RecalcStyleDeferred (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
Reviewers:
ojan, adamk, eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Setting HTMLStyleElement should use RecalcStyleDeferred Theres no reason to synchronously recalc style whenever you change the media attribute of a <style>. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
6 years, 9 months ago (2014-03-19 22:23:25 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-19 23:09:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/205463002/1
6 years, 9 months ago (2014-03-19 23:09:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:11:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-19 23:11:09 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-19 23:23:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/205463002/1
6 years, 9 months ago (2014-03-19 23:23:11 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 00:25:01 UTC) #8
Message was sent while issue was closed.
Change committed as 169596

Powered by Google App Engine
This is Rietveld 408576698