Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2054593002: Remove MaxSharedMemorySize() function from SysInfo (Closed)

Created:
4 years, 6 months ago by xyzzyz
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MaxSharedMemorySize() function from SysInfo It is not used anywhere, and is only supported on some platforms. In addition, it synchronously reads a file during Zygote startup. Last use was removed in 2014: 1cf03f7f0c2eff4e34b6d6e4a088dcbd762ee9b9 BUG= Committed: https://crrev.com/6f104bf7f475f185dff31647dc911595e943df42 Cr-Commit-Position: refs/heads/master@{#398926}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M base/sys_info.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/sys_info_linux.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/initialize_base_and_icu.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M services/shell/runner/host/child_process_base.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
xyzzyz
4 years, 6 months ago (2016-06-08 23:59:25 UTC) #4
Nico
lgtm
4 years, 6 months ago (2016-06-09 00:04:02 UTC) #5
mdempsky
rslgtm for content/zygote
4 years, 6 months ago (2016-06-09 00:17:23 UTC) #6
mdempsky
On 2016/06/09 00:17:23, mdempsky wrote: > rslgtm for content/zygote blah, lgtm
4 years, 6 months ago (2016-06-09 00:17:31 UTC) #7
Anand Mistry (off Chromium)
lgtm for services/shell
4 years, 6 months ago (2016-06-09 01:35:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054593002/20001
4 years, 6 months ago (2016-06-09 17:17:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 17:21:58 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 17:22:18 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 17:24:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f104bf7f475f185dff31647dc911595e943df42
Cr-Commit-Position: refs/heads/master@{#398926}

Powered by Google App Engine
This is Rietveld 408576698