Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2054573002: Remove MessageLoop::current()->task_runner() in ui. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::current()->task_runner() in ui. This CL replaces MessageLoop::current()->task_runner() with ThreadTaskRunnerHandle::Get() in ui. In files where this replacement is made, it adds these include: #include "base/threading/thread_task_runner_handle.h" #include "base/location.h" (if required) #include "base/single_thread_task_runner.h" (if required) And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop but they will have access to a ThreadTaskRunnerHandle. Steps to generate this patch: 1. Run message_loop_cleanup_2.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=thakis@chromium.org Committed: https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98 Cr-Commit-Position: refs/heads/master@{#399739}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M ui/accelerated_widget_mac/display_link_mac.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/base/test/windowed_nsnotification_observer.mm View 2 chunks +4 lines, -1 line 0 comments Download
M ui/snapshot/screenshot_grabber.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-09 13:21:49 UTC) #1
fdoray
4 years, 6 months ago (2016-06-13 21:04:34 UTC) #3
fdoray
+sky@: Can you review this CL? (Nico traveling)
4 years, 6 months ago (2016-06-13 21:04:39 UTC) #4
Nico
lgtm
4 years, 6 months ago (2016-06-14 13:15:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054573002/20001
4 years, 6 months ago (2016-06-14 16:56:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 17:47:25 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 17:47:38 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:50:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98
Cr-Commit-Position: refs/heads/master@{#399739}

Powered by Google App Engine
This is Rietveld 408576698