Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2054483002: Revert of cc : Make LayerImpl destruction independent of tree hierarchy (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jaydasika, ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ ) Reason for revert: Tentative revert for strange linker failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/156821 I already tried reverting the other CL in the blame list (mine) with no success. Doesn't make sense that this CL would cause it either, but just ruling it out. I'll revert the revert if the builder stays red. Original issue's description: > cc : Make LayerImpl destruction independent of tree hierarchy > > Instead of deleting all layers when the root is deleted, we delete > all layers when the layer tree impl is shutdown. > > BUG=617791 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14 > Cr-Commit-Position: refs/heads/master@{#398606} TBR=ajuma@chromium.org,weiliangc@chromium.org,jaydasika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617791 Committed: https://crrev.com/f3a9e5397cce794930f73f6c6a43c0621ecf06a6 Cr-Commit-Position: refs/heads/master@{#398623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -30 lines) Patch
M cc/layers/layer_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of cc : Make LayerImpl destruction independent of tree hierarchy
4 years, 6 months ago (2016-06-08 18:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054483002/1
4 years, 6 months ago (2016-06-08 18:23:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 18:24:12 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3a9e5397cce794930f73f6c6a43c0621ecf06a6 Cr-Commit-Position: refs/heads/master@{#398623}
4 years, 6 months ago (2016-06-08 18:25:24 UTC) #6
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-06-08 19:06:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2048863003/ by rockot@chromium.org.

The reason for reverting is: Didn't fix anything.

Powered by Google App Engine
This is Rietveld 408576698