Schedule download resumption automatically

Schedule download resumption automatically

Currently, Chrome will not resume download automatically if browser is
killed.
This experience is inferior to that of the Android DownloadManager.
This change automatically reschedules the download after browser is
killed.
It uses GCMNetworkManager schedule the task, similar to
background sync, offline pages, etc.

BUG=617797
Committed: https://crrev.com/d8da6fb2b48ddaa8f83f7cb1db7e1cca9938da75
Cr-Commit-Position: refs/heads/master@{#399780}

[qinmin, 2016-06-08 18:17:51]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-06-08 18:17:52]

PTAL

[qinmin, 2016-06-09 23:27:46]

Patchset #1 (id:1) has been deleted

[Ted C, 2016-06-10 00:08:26]

lgtm

https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java
(right):

https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java:33:
sDownloadResumptionScheduler = new DownloadResumptionScheduler(context);
can we add an assert that it is an application context?

[qinmin, 2016-06-10 21:58:39]

https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java
(right):

https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java:33:
sDownloadResumptionScheduler = new DownloadResumptionScheduler(context);
On 2016/06/10 00:08:26, Ted C wrote:
> can we add an assert that it is an application context?

Done.

[qinmin, 2016-06-10 21:58:45]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-10 21:58:46]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2054463003/#ps40001
(title: "passing application context")

[commit-bot: I haz the power, 2016-06-10 21:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463003/40001

[commit-bot: I haz the power, 2016-06-11 01:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-11 01:38:25]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qinmin, 2016-06-13 17:21:57]

Patchset #3 (id:60001) has been deleted

[qinmin, 2016-06-13 17:22:09]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 17:22:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463003/80001

[qinmin, 2016-06-13 19:07:19]

Patchset #3 (id:80001) has been deleted

[qinmin, 2016-06-13 22:26:50]

Patchset #3 (id:100001) has been deleted

[qinmin, 2016-06-13 22:26:59]

Patchset #3 (id:120001) has been deleted

[qinmin, 2016-06-13 22:56:31]

Patchset #3 (id:140001) has been deleted

[qinmin, 2016-06-13 23:36:18]

Patchset #3 (id:160001) has been deleted

[qinmin, 2016-06-14 16:16:24]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-14 16:16:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2054463003/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-14 16:16:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463003/180001

[commit-bot: I haz the power, 2016-06-14 17:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 17:28:18]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[qinmin, 2016-06-14 19:03:33]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-14 19:03:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2054463003/#ps200001
(title: "fix clang build")

[commit-bot: I haz the power, 2016-06-14 19:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463003/200001

[commit-bot: I haz the power, 2016-06-14 19:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:25:46]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[qinmin, 2016-06-14 19:35:35]

Patchset #4 (id:200001) has been deleted

[qinmin, 2016-06-14 19:35:59]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-14 19:36:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2054463003/#ps220001
(title: "fix clang build")

[commit-bot: I haz the power, 2016-06-14 19:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463003/220001

[commit-bot: I haz the power, 2016-06-14 20:32:53]

Description was changed from

==========
Schedule download resumption automatically

Currently, Chrome will not resume download automatically if browser is
killed.
This experience is inferior to that of the Android DownloadManager.
This change automatically reschedules the download after browser is
killed.
It uses GCMNetworkManager schedule the task, similar to
background sync, offline pages, etc.

BUG=617797
==========

to

==========
Schedule download resumption automatically

Currently, Chrome will not resume download automatically if browser is
killed.
This experience is inferior to that of the Android DownloadManager.
This change automatically reschedules the download after browser is
killed.
It uses GCMNetworkManager schedule the task, similar to
background sync, offline pages, etc.

BUG=617797

Committed: https://crrev.com/d8da6fb2b48ddaa8f83f7cb1db7e1cca9938da75
Cr-Commit-Position: refs/heads/master@{#399780}
==========

[commit-bot: I haz the power, 2016-06-14 20:32:55]

Patchset 4 (id:??) landed as
https://crrev.com/d8da6fb2b48ddaa8f83f7cb1db7e1cca9938da75
Cr-Commit-Position: refs/heads/master@{#399780}