Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2054463003: Schedule download resumption automatically (Closed)

Created:
4 years, 6 months ago by qinmin
Modified:
4 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Schedule download resumption automatically Currently, Chrome will not resume download automatically if browser is killed. This experience is inferior to that of the Android DownloadManager. This change automatically reschedules the download after browser is killed. It uses GCMNetworkManager schedule the task, similar to background sync, offline pages, etc. BUG=617797 Committed: https://crrev.com/d8da6fb2b48ddaa8f83f7cb1db7e1cca9938da75 Cr-Commit-Position: refs/heads/master@{#399780}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : passing application context #

Patch Set 3 : rebase #

Patch Set 4 : fix clang build #

Messages

Total messages: 34 (22 generated)
qinmin
PTAL
4 years, 6 months ago (2016-06-08 18:17:52 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java (right): https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java#newcode33 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java:33: sDownloadResumptionScheduler = new DownloadResumptionScheduler(context); can we add an ...
4 years, 6 months ago (2016-06-10 00:08:26 UTC) #4
qinmin
https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java (right): https://codereview.chromium.org/2054463003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java#newcode33 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java:33: sDownloadResumptionScheduler = new DownloadResumptionScheduler(context); On 2016/06/10 00:08:26, Ted C ...
4 years, 6 months ago (2016-06-10 21:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054463003/40001
4 years, 6 months ago (2016-06-10 21:59:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86272)
4 years, 6 months ago (2016-06-11 01:38:25 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054463003/80001
4 years, 6 months ago (2016-06-13 17:22:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054463003/180001
4 years, 6 months ago (2016-06-14 16:16:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/81420)
4 years, 6 months ago (2016-06-14 17:28:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054463003/200001
4 years, 6 months ago (2016-06-14 19:03:51 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/81255)
4 years, 6 months ago (2016-06-14 19:25:46 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054463003/220001
4 years, 6 months ago (2016-06-14 19:36:21 UTC) #32
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 20:32:55 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d8da6fb2b48ddaa8f83f7cb1db7e1cca9938da75
Cr-Commit-Position: refs/heads/master@{#399780}

Powered by Google App Engine
This is Rietveld 408576698