Add Mojo structs and StructTraits for //ui/events/devices.

Add Mojo structs and StructTraits for //ui/events/devices.

Add structs for ui::InputDevice and ui::TouchscreenDevice so they can be
shared between processes. Add StructTraits for the structs for automatic
type conversions.

The Mojo structs used composition instead of inheritance, as inheritance
is unsupported.

BUG=601981
Committed: https://crrev.com/f1684a532b1eb8f8182d4f3a2298c045bf0489be
Cr-Commit-Position: refs/heads/master@{#398942}

[kylechar, 2016-06-08 18:01:01]

kylechar@chromium.org changed reviewers:
+ rockot@chromium.org, tsepez@chromium.org

[kylechar, 2016-06-08 18:01:01]

tsepez@ for ui/events/devices/mojo/*
rocket@ for mojo/*

[Tom Sepez, 2016-06-08 18:24:56]

lgtm

[Ken Rockot(use gerrit already), 2016-06-08 18:30:01]

lgtm

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/inpu...
File ui/events/devices/mojo/input_device.typemap (right):

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/inpu...
ui/events/devices/mojo/input_device.typemap:10: deps = [
Please change this to public_deps since it's exposed by the public headers

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/touc...
File ui/events/devices/mojo/touchscreen_device.typemap (right):

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/touc...
ui/events/devices/mojo/touchscreen_device.typemap:10: deps = [
Please move //ui/events/devices to public_deps since it's exposed by the public
headers

[kylechar, 2016-06-09 13:14:26]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-06-09 13:14:27]

Thanks for the quick review.. +sadrul@ for the not mojom/struct_traits.

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/inpu...
File ui/events/devices/mojo/input_device.typemap (right):

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/inpu...
ui/events/devices/mojo/input_device.typemap:10: deps = [
On 2016/06/08 18:30:01, Ken Rockot wrote:
> Please change this to public_deps since it's exposed by the public headers

Done.

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/touc...
File ui/events/devices/mojo/touchscreen_device.typemap (right):

https://codereview.chromium.org/2054463002/diff/1/ui/events/devices/mojo/touc...
ui/events/devices/mojo/touchscreen_device.typemap:10: deps = [
On 2016/06/08 18:30:01, Ken Rockot wrote:
> Please move //ui/events/devices to public_deps since it's exposed by the
public
> headers

Done.

[sadrul, 2016-06-09 14:21:46]

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/input_device_struct_traits.h (right):

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/input_device_struct_traits.h:73: out->sys_path =
base::FilePath::FromUTF8Unsafe(sys_path_string);
Should we be using FromUTF8Unsafe() on something we are receiving from a remote
client?

[kylechar, 2016-06-09 14:42:15]

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/input_device_struct_traits.h (right):

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/input_device_struct_traits.h:73: out->sys_path =
base::FilePath::FromUTF8Unsafe(sys_path_string);
On 2016/06/09 14:21:45, sadrul wrote:
> Should we be using FromUTF8Unsafe() on something we are receiving from a
remote
> client?

My understanding is that the decoding/encoding of the filepath internal
representation to UTF8 might be unsafe (aka it could mangle the path depending
on filesystem locale). The path is just compared against in
ash::GetUdlAssociationScore(), it's never opened, so there is little to no risk
I think?

The comments in FilePath indicate there is no perfect way to encode a FilePath
to a string and that the choices are ASCII, UTF8 or UTF16. UTF8 seems right to
me?

[sadrul, 2016-06-09 15:09:19]

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/input_device_struct_traits.h (right):

https://codereview.chromium.org/2054463002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/input_device_struct_traits.h:73: out->sys_path =
base::FilePath::FromUTF8Unsafe(sys_path_string);
On 2016/06/09 14:42:14, kylechar wrote:
> On 2016/06/09 14:21:45, sadrul wrote:
> > Should we be using FromUTF8Unsafe() on something we are receiving from a
> remote
> > client?
> 
> My understanding is that the decoding/encoding of the filepath internal
> representation to UTF8 might be unsafe (aka it could mangle the path depending
> on filesystem locale). The path is just compared against in
> ash::GetUdlAssociationScore(), it's never opened, so there is little to no
risk
> I think?

For now, yeah. It'd be difficult to restrict how it's used in the future though.

I wanted to make sure we didn't accidentally overlook this. But as long as sec.
folks are happy, I am happy. lgtm

[kylechar, 2016-06-09 16:49:09]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-09 16:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2054463002/#ps20001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-06-09 16:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054463002/20001

[commit-bot: I haz the power, 2016-06-09 17:54:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 17:54:55]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 18:00:01]

Description was changed from

==========
Add Mojo structs and StructTraits for //ui/events/devices.

Add structs for ui::InputDevice and ui::TouchscreenDevice so they can be
shared between processes. Add StructTraits for the structs for automatic
type conversions.

The Mojo structs used composition instead of inheritance, as inheritance
is unsupported.

BUG=601981
==========

to

==========
Add Mojo structs and StructTraits for //ui/events/devices.

Add structs for ui::InputDevice and ui::TouchscreenDevice so they can be
shared between processes. Add StructTraits for the structs for automatic
type conversions.

The Mojo structs used composition instead of inheritance, as inheritance
is unsupported.

BUG=601981

Committed: https://crrev.com/f1684a532b1eb8f8182d4f3a2298c045bf0489be
Cr-Commit-Position: refs/heads/master@{#398942}
==========

[commit-bot: I haz the power, 2016-06-09 18:00:02]

Patchset 2 (id:??) landed as
https://crrev.com/f1684a532b1eb8f8182d4f3a2298c045bf0489be
Cr-Commit-Position: refs/heads/master@{#398942}