Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2054453002: Make possible to don't track cache dependencies. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make possible to don't track cache dependencies. If 'trackCacheDependencies' is set to 'false', this makes DDC compilation of Angular2 project about 10% faster. Unfortunately I was not able to avoid creating ResultDescriptor(s) and adding them into WorkItem.inputTargetedResults altogether. It is used in AnalysisTask._findCyclicPath() to create InfiniteTaskLoopException with additional information. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d7ec8ca711ece3db0204d826b20696e7217a7525

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +12 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-08 17:43:36 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2054453002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/2054453002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1149 pkg/analyzer/lib/src/generated/engine.dart:1149: * is performed in batch mode, so that ...
4 years, 6 months ago (2016-06-08 17:48:04 UTC) #2
scheglov
4 years, 6 months ago (2016-06-09 15:23:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7ec8ca711ece3db0204d826b20696e7217a7525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698