third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h - Issue 2054433002: Implement "create an element" when sync for Custom Element V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce

Patch Set: Fix building tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

index fb46146a12422198b4964149c9e4ca49ee22a1ac..a99e9a42a2f5578a9744dbb95aa0d86baec47fb4 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

@@ -13,8 +13,9 @@

namespace blink {

-class ScriptState;

class Element;

+class HTMLElement;

+class QualifiedName;

class CORE_EXPORT CustomElementDefinition

: public GarbageCollectedFinalized<CustomElementDefinition> {

@@ -41,6 +42,9 @@ public:

return m_constructionStack;

}

+ virtual HTMLElement* createCustomElement(Document&, const QualifiedName&) = 0;

+ virtual HTMLElement* createCustomElementIgnoringErrors(Document&, const QualifiedName&) = 0;

void upgrade(Element*);

protected: