third_party/WebKit/Source/core/dom/custom/CustomElement.h - Issue 2054433002: Implement "create an element" when sync for Custom Element V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElement.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce

Patch Set: haraken review and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.idl ('k') | third_party/WebKit/Source/core/dom/custom/CustomElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElement.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.h b/third_party/WebKit/Source/core/dom/custom/CustomElement.h

index 727e227c424b554c54252436519c9fa0c87a2d96..080ac2b2f8da48d5cbb709bc60d7d53d068cff7e 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.h

@@ -37,8 +37,10 @@ public:

static bool shouldCreateCustomElement(Document&, const AtomicString& localName);

static bool shouldCreateCustomElement(Document&, const QualifiedName&);

- static HTMLElement* createCustomElement(Document&, const AtomicString& localName, CreateElementFlags);

- static HTMLElement* createCustomElement(Document&, const QualifiedName&, CreateElementFlags);

+ static HTMLElement* createCustomElementSync(Document&, const AtomicString& localName, ExceptionState&);

+ static HTMLElement* createCustomElementSync(Document&, const QualifiedName&, ExceptionState&);

+ static HTMLElement* createCustomElementSync(Document&, const QualifiedName&);

+ static HTMLElement* createCustomElementAsync(Document&, const QualifiedName&);

static void enqueueConnectedCallback(Element*);

static void enqueueDisconnectedCallback(Element*);

@@ -46,8 +48,7 @@ public:

const AtomicString& oldValue, const AtomicString& newValue);

private:

- static HTMLElement* createCustomElementAsync(Document&, CustomElementDefinition&, const QualifiedName&);

+ static HTMLElement* createUndefinedElement(Document&, const QualifiedName&);

};

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.idl ('k') | third_party/WebKit/Source/core/dom/custom/CustomElement.cpp » ('j') | no next file with comments »