third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl - Issue 2054433002: Implement "create an element" when sync for Custom Element V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce

Patch Set: haraken review and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

index 7b7e9def78679f001184fff8bb1d1f579f2e9a16..d8e96407835569f7fa29bd4e000178be6f044785 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

@@ -90,8 +90,12 @@ static void create{{namespace}}FunctionMap()

return function(document, {% if namespace == 'HTML' %}formElement, {% endif %}flags);

{% if namespace == 'HTML' %}

- if (CustomElement::shouldCreateCustomElement(document, localName))

- return CustomElement::createCustomElement(document, localName, flags);

+ if (CustomElement::shouldCreateCustomElement(document, localName)) {

+ QualifiedName tagName(nullAtom, localName, HTMLNames::xhtmlNamespaceURI);

+ if (flags & AsynchronousCustomElements)

+ return CustomElement::createCustomElementAsync(document, tagName);

+ return CustomElement::createCustomElementSync(document, tagName);

+ }

{% endif %}

if (document.registrationContext() && V0CustomElement::isValidName(localName)) {