third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2054433002: Implement "create an element" when sync for Custom Element V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce

Patch Set: haraken review and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/create-element-defined-synchronous.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index c2b10c03da91e9a412ea1ae7f859050a70106726..8d8cdd4be35f38cca3880114de36dd06b0f2603e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -46,6 +46,9 @@ public:

v8::Local<v8::Object> constructor() const;

v8::Local<v8::Object> prototype() const;

+ HTMLElement* createElementSync(Document&, const QualifiedName&) override;

+ HTMLElement* createElementSync(Document&, const QualifiedName&, ExceptionState&) override;

private:

ScriptCustomElementDefinition(

ScriptState*,

@@ -60,6 +63,7 @@ private:

// Implementations of |CustomElementDefinition|

ScriptValue getConstructorForScript() final;

bool runConstructor(Element*) override;

+ Element* runConstructor();

RefPtr<ScriptState> m_scriptState;

ScopedPersistent<v8::Object> m_constructor;