Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElement.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce
Patch Set: dominicc review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElement.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.h b/third_party/WebKit/Source/core/dom/custom/CustomElement.h
index b4637109016095e548aa896aefdf71e9aaad1d7d..6150639f11d57abeebcc049d56089a2ff1bbe615 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.h
@@ -29,6 +29,8 @@ public:
static CustomElementsRegistry* registry(const Element&);
static CustomElementsRegistry* registry(const Document&);
+ static CustomElementDefinition* definitionForName(const Document&, const AtomicString& name);
+
// Returns true if element could possibly match a custom element
// descriptor *now*. See CustomElementDescriptor::matches for the
// meaning of "match". Custom element processing which depends on
@@ -54,13 +56,15 @@ public:
static bool shouldCreateCustomElement(Document&, const AtomicString& localName);
static bool shouldCreateCustomElement(Document&, const QualifiedName&);
- static HTMLElement* createCustomElement(Document&, const AtomicString& localName, CreateElementFlags);
- static HTMLElement* createCustomElement(Document&, const QualifiedName&, CreateElementFlags);
+ static HTMLElement* createCustomElementSync(Document&, const AtomicString& localName, ExceptionState&);
+ static HTMLElement* createCustomElementSync(Document&, const QualifiedName&, ExceptionState&);
+ static HTMLElement* createCustomElementSync(Document&, const QualifiedName& localName);
dominicc (has gone to gerrit) 2016/06/13 07:37:24 Be consistent about whether you are naming the loc
kojii 2016/06/13 13:44:31 Done.
+ static HTMLElement* createCustomElementAsync(Document&, const QualifiedName&);
static void enqueueUpgradeReaction(Element*, CustomElementDefinition*);
private:
- static HTMLElement* createCustomElementAsync(Document&, CustomElementDefinition&, const QualifiedName&);
+ static HTMLElement* createUndefinedElement(Document&, const QualifiedName&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698