third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp - Issue 2054433002: Implement "create an element" when sync for Custom Element V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce

Patch Set: Prefer ExceptionState over throw Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

index ea1d265c8cbb8f2f6920e49d58ba72bef9f3ca70..1a8b360e8c8c7070510136a61b44c66d7890a953 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

@@ -247,6 +247,16 @@ public:

element->setCustomElementState(CustomElementState::Custom);

return true;

}

+ HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&) override

+ {

+ return nullptr;

+ }

+ HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&, ExceptionState&) override

+ {

+ return nullptr;

+ }

};

// Classes which use trace macros cannot be local because of the