Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce
Patch Set: Prefer ExceptionState over throw Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index fb46146a12422198b4964149c9e4ca49ee22a1ac..f2ee2465387762dfc653bc138338d6511fa605a6 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -13,8 +13,10 @@
namespace blink {
-class ScriptState;
dominicc (has gone to gerrit) 2016/06/10 06:13:28 Thanks for cleaning this up.
class Element;
+class ExceptionState;
+class HTMLElement;
+class QualifiedName;
class CORE_EXPORT CustomElementDefinition
: public GarbageCollectedFinalized<CustomElementDefinition> {
@@ -41,11 +43,16 @@ public:
return m_constructionStack;
}
+ virtual HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&) = 0;
dominicc (has gone to gerrit) 2016/06/10 06:13:28 Maybe call this createElementSync to match the nam
kojii 2016/06/10 19:01:45 Done.
+ virtual HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&, ExceptionState&) = 0;
+
void upgrade(Element*);
protected:
virtual bool runConstructor(Element*) = 0;
+ static void errorForConstructorResult(Element*, Document&, const QualifiedName&, ExceptionState&);
+
private:
const CustomElementDescriptor m_descriptor;
ConstructionStack m_constructionStack;

Powered by Google App Engine
This is Rietveld 408576698