Implement "create an element" when sync for Custom Element V1

third_party/WebKit/Source/core/dom/Document.h

Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index e9a814b8edf0630505a3b5af6d83219a7dbca997..1904a98dc1c1c4c536c9fced4ea92208ee9e6032 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -309,6 +309,7 @@ public:
     Node* importNode(Node* importedNode, bool deep, ExceptionState&);
     Element* createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
     Element* createElement(const QualifiedName&, CreateElementFlags);
+    Element* createElement(const QualifiedName&, CreateElementFlags, ExceptionState&);

[dominicc (has gone to gerrit), 2016/06/10 06:13:28]

OK now I'm really confused. Who uses *this*?

I think we're adding too many methods called createElement, and we don't have
good layering. Instead of having everything calling everything and using flags
to control where the recursion bottoms out, we need a each method to have a
distinct responsibility.

So, what do we absolutely need:

Document::createElement(NS) for the DOM callbacks. These can call
CustomElement::createElementSync.
Document::createElement for cloning, etc. This calls HTMLElementFactory.
CustomElement::createElementSync which swallows (and reports) exceptions. This
is called by the parser. Calls HTMLElementFactory.
HTMLElementFactory::create. This actually creates elements.

The only question is where create-and-queue-upgrade happens. That could be
HTMLElementFactory, but it needs an option to turn it off (for
createElementSync.) Or it could be Document::createElement.

is="" means probably HTMLElementFactory should do *less* and *not* schedule
upgrade. The reason is HTMLElementFactory::create does NOT get the attribute
list, so it CAN NOT KNOW which definition to queue upgrade with.

So, again, I really think we need fewer createElement methods and fewer flags to
HTMLElementFactory.

I am fine to go in and do this refactoring. But it would be get this patch
committed. So let's not make the clean up more difficult by adding more
createElement methods, more use of flags in this patch.

[kojii, 2016/06/10 19:01:45]

Done. took some refactoring, but not all yet.

 
     Element* elementFromPoint(int x, int y) const;
     HeapVector<Member<Element>> elementsFromPoint(int x, int y) const;