Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/compiler/instruction.cc

Issue 2054343002: [Turbofan] Make operand canonicalization distinguish between FP types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Clean up. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/instruction.cc
diff --git a/src/compiler/instruction.cc b/src/compiler/instruction.cc
index b461c5d8965839a587e5c26c63f97a73cb0d3d3e..8f12efe7cb11458e29915df89aff3559e86187b1 100644
--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -59,6 +59,11 @@ FlagsCondition CommuteFlagsCondition(FlagsCondition condition) {
return condition;
}
+bool InstructionOperand::InterferesWith(const InstructionOperand& that) const {
+ if (!IsFPRegister() || !that.IsFPRegister()) return EqualsCanonicalized(that);
+ return LocationOperand::cast(this)->register_code() ==
+ LocationOperand::cast(that).register_code();
+}
void InstructionOperand::Print(const RegisterConfiguration* config) const {
OFStream os(stdout);
@@ -75,7 +80,6 @@ void InstructionOperand::Print() const {
Print(config);
}
-
std::ostream& operator<<(std::ostream& os,
const PrintableInstructionOperand& printable) {
const InstructionOperand& op = printable.op_;
@@ -181,7 +185,6 @@ std::ostream& operator<<(std::ostream& os,
return os;
}
-
void MoveOperands::Print(const RegisterConfiguration* config) const {
OFStream os(stdout);
PrintableInstructionOperand wrapper;

Powered by Google App Engine
This is Rietveld 408576698