[Turbofan] Make operand canonicalization distinguish between FP types.

[Turbofan] Make operand canonicalization distinguish between FP types.

Committed: https://crrev.com/70d83fbdd1bf88201ccefa3ee788f3ee240d1c1e
Cr-Commit-Position: refs/heads/master@{#37013}

[bbudge, 2016-06-14 23:34:23]

bbudge@chromium.org changed reviewers:
+ bmeurer@chromium.org, mtrofin@chromium.org

[bbudge, 2016-06-14 23:34:24]

Tests seem to pass, but I'm not convinced I've found all the places where
register-register interference needs to be checked.

https://codereview.chromium.org/2054343002/diff/80001/src/compiler/gap-resolv...
File src/compiler/gap-resolver.cc (right):

https://codereview.chromium.org/2054343002/diff/80001/src/compiler/gap-resolv...
src/compiler/gap-resolver.cc:78: if (source.InterferesWith(destination)) {
This is necessary to avoid an assert on line 95, but the comment implies that
source and destination should be the same type (since it's a move cycle and
moves have a single rep for src and dst). However, that doesn't seem to be what
happens at run time.

https://codereview.chromium.org/2054343002/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (left):

https://codereview.chromium.org/2054343002/diff/80001/src/compiler/instructio...
src/compiler/instruction.h:605: // TODO(dcarney): put machine type last and
mask.
I removed this because I don't understand what it means, so assuming it's
obsolete.

[Benedikt Meurer, 2016-06-15 03:32:33]

LGTM.

[bbudge, 2016-06-15 18:46:59]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2016-06-15 18:47:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054343002/80001

[commit-bot: I haz the power, 2016-06-15 18:49:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-15 18:52:35]

Description was changed from

==========
[Turbofan] Make operand canonicalization distinguish between FP types.
==========

to

==========
[Turbofan] Make operand canonicalization distinguish between FP types.

Committed: https://crrev.com/70d83fbdd1bf88201ccefa3ee788f3ee240d1c1e
Cr-Commit-Position: refs/heads/master@{#37013}
==========

[commit-bot: I haz the power, 2016-06-15 18:52:36]

Patchset 5 (id:??) landed as
https://crrev.com/70d83fbdd1bf88201ccefa3ee788f3ee240d1c1e
Cr-Commit-Position: refs/heads/master@{#37013}