Fix exit detection for try statements.

Fix exit detection for try statements.

Previously, we assumed that if the contents of the "try" block always
exit, then the whole try statement always exits.  But this is not
correct if there is at least one catch handler that does not exit.

Fixes #26676

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/7653369e50da13ac66111bab0311c6cf9ddcf5a5

[Paul Berry, 2016-06-10 23:44:00]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-11 00:13:40]

lgtm

https://codereview.chromium.org/2054323002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2054323002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3790: void
test_tryStatement_return_try_noCatch() {
Strangely enough, all of the tests use a try statement that includes a finally
block, seems like we ought to test at least one case without a finally block.

[Paul Berry, 2016-06-11 13:02:15]

https://codereview.chromium.org/2054323002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2054323002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3790: void
test_tryStatement_return_try_noCatch() {
On 2016/06/11 00:13:39, Brian Wilkerson wrote:
> Strangely enough, all of the tests use a try statement that includes a finally
> block, seems like we ought to test at least one case without a finally block.

Done.

[Paul Berry, 2016-06-11 13:06:47]

Description was changed from

==========
Fix exit detection for try statements.

Previously, we assumed that if the contents of the "try" block always
exit, then the whole try statement always exits.  But this is not
correct if there is at least one catch handler that does not exit.

Fixes #26676
==========

to

==========
Fix exit detection for try statements.

Previously, we assumed that if the contents of the "try" block always
exit, then the whole try statement always exits.  But this is not
correct if there is at least one catch handler that does not exit.

Fixes #26676

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7653369e50da13ac66111bab0311c6cf9ddcf5a5
==========

[Paul Berry, 2016-06-11 13:06:49]

Committed patchset #2 (id:20001) manually as
7653369e50da13ac66111bab0311c6cf9ddcf5a5 (presubmit successful).

[srawlins, 2016-06-14 16:16:49]

On 2016/06/11 13:06:49, Paul Berry wrote:
> Committed patchset #2 (id:20001) manually as
> 7653369e50da13ac66111bab0311c6cf9ddcf5a5 (presubmit successful).

Thanks so much Paul!! Especially for all the tests!