Kill child processes on bad Mojo messages

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 766 matching lines @@
     if (!renderer_prefix.empty())
       cmd_line->PrependWrapper(renderer_prefix);
     AppendRendererCommandLine(cmd_line);
     cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
 
     // Spawn the child process asynchronously to avoid blocking the UI thread.
     // As long as there's no renderer prefix, we can use the zygote process
     // at this stage.
     child_process_launcher_.reset(new ChildProcessLauncher(
         new RendererSandboxedProcessLauncherDelegate(channel_.get()), cmd_line,
-        GetID(), this, child_token_));
+        GetID(), this, child_token_,
+        base::Bind(&RenderProcessHostImpl::OnMojoProcessError,
+                   weak_factory_.GetWeakPtr())));
 
     fast_shutdown_started_ = false;
   }
 
   if (!gpu_observer_registered_) {
     gpu_observer_registered_ = true;
     ui::GpuSwitchingManager::GetInstance()->AddObserver(this);
   }
 
   power_monitor_broadcaster_.Init();
@@ skipping 1822 matching lines @@
   // sent a RenderProcessHostDestroyed notification, and we must observe our
   // contract that says that will be the last call.
   if (deleting_soon_)
     return;
 
   RendererClosedDetails details{base::TERMINATION_STATUS_LAUNCH_FAILED,
                                 error_code};
   ProcessDied(true, &details);
 }
 
+void RenderProcessHostImpl::OnMojoProcessError(const std::string& error) {
+  // The ReceivedBadMessage call below will trigger a DumpWithoutCrashing. Alias
+  // enough information here so that we can determine what the bad message was.
+  base::debug::Alias(&error);
+  bad_message::ReceivedBadMessage(this,
+                                  bad_message::RPH_MOJO_PROCESS_ERROR);
+  LOG(ERROR) << "Killing render process process: " << error;

[jam, 2016/06/13 18:30:39]

nit: no need, since bad_message::ReceivedBadMessage does this

[Ken Rockot(use gerrit already), 2016/06/13 22:36:40]

The message logged by ReceivedBadMessage is not particularly useful for a
developer encountering this. The message here may include details about the
specific Mojo interface and method name which triggered the error.

+}
+
 scoped_refptr<AudioRendererHost> RenderProcessHostImpl::audio_renderer_host()
     const {
   return audio_renderer_host_;
 }
 
 void RenderProcessHostImpl::OnUserMetricsRecordAction(
     const std::string& action) {
   RecordComputedAction(action);
 }
 
@@ skipping 160 matching lines @@
 
     // Skip widgets in other processes.
     if (rvh->GetProcess()->GetID() != GetID())
       continue;
 
     rvh->OnWebkitPreferencesChanged();
   }
 }
 
 }  // namespace content