Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2054293002: Revert of Disable blink layout tests related to crbug/254639 + (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable blink layout tests related to crbug/254639 + (patchset #1 id:1 of https://codereview.chromium.org/2059723002/ ) Reason for revert: Context menu is broken on Linux: https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing BUG=619185 Original issue's description: > Disable blink layout tests related to crbug/254639 + > crbug.com/254639 css3/filters/effect-brightness-hw.html [ Failure Pass ] > crbug.com/254639 css3/filters/effect-hue-rotate-hw.html [ Failure Pass ] > > TBR=enne@chromium.org > BUG=254639 > > Committed: https://chromium.googlesource.com/chromium/src/+/2af0f64999cc750dadcc0ba17b7cb7e8fe9a9563 TBR=enne@chromium.org,perkj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=254639 Committed: https://crrev.com/8bf22b3aae1b9b00b60874505c4ec22279236c8f Cr-Commit-Position: refs/heads/master@{#399303}

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kozy
Created Revert of Disable blink layout tests related to crbug/254639 +
4 years, 6 months ago (2016-06-10 22:31:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054293002/1
4 years, 6 months ago (2016-06-10 22:32:59 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-10 22:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054293002/40001
4 years, 6 months ago (2016-06-10 22:42:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-10 22:43:22 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 22:43:27 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 22:45:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bf22b3aae1b9b00b60874505c4ec22279236c8f
Cr-Commit-Position: refs/heads/master@{#399303}

Powered by Google App Engine
This is Rietveld 408576698