content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc - Issue 2054273002: Font fallback for UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc

Issue 2054273002: Font fallback for UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix clang build error due to signed-unsigned comparison Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/url_formatter/elide_url_unittest.cc ('k') | content/child/dwrite_font_proxy/font_fallback_win_unittest.cc » ('j') | ui/gfx/font_fallback_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc

diff --git a/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc b/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc

index 6db1c1b24972b3517c03a2fbdab0ac08542323cd..b7f0a6c7735d712da70897fb835a79f36c377846 100644

--- a/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc

+++ b/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc

@@ -20,9 +20,9 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "content/common/dwrite_font_proxy_messages.h"

-#include "content/common/dwrite_text_analysis_source_win.h"

#include "ipc/ipc_message_macros.h"

#include "ui/gfx/win/direct_write.h"

+#include "ui/gfx/win/text_analysis_source.h"

namespace mswr = Microsoft::WRL;

@@ -258,7 +258,7 @@ void DWriteFontProxyMessageFilter::OnMapCharacters(

return;

}

mswr::ComPtr<IDWriteTextAnalysisSource> analysis_source;

- if (FAILED(mswr::MakeAndInitialize<TextAnalysisSource>(

+ if (FAILED(mswr::MakeAndInitialize<gfx::win::TextAnalysisSource>(

&analysis_source, text, locale_name, number_substitution.Get(),

static_cast<DWRITE_READING_DIRECTION>(reading_direction)))) {

DCHECK(false);