Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/text_elider_unittest.cc

Issue 2054273002: Font fallback for UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/render_text_unittest.cc ('K') | « ui/gfx/render_text_unittest.cc ('k') | ui/gfx/win/dwrite_text_analysis_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/text_elider_unittest.cc
diff --git a/ui/gfx/text_elider_unittest.cc b/ui/gfx/text_elider_unittest.cc
index cb26c48dd9dee4db64f513fc897f162e67c9acfb..500e25d0c45bc845772634e813861ca9f407a3d5 100644
--- a/ui/gfx/text_elider_unittest.cc
+++ b/ui/gfx/text_elider_unittest.cc
@@ -14,6 +14,7 @@
#include "base/files/file_path.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
+#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
@@ -330,6 +331,10 @@ static void CheckCodeUnitPairs(const base::string16& text,
#define MAYBE_ElideTextAtomicSequences ElideTextAtomicSequences
#endif
TEST(TextEliderTest, MAYBE_ElideTextAtomicSequences) {
+#if defined(OS_WIN)
+ // Needed to bypass DCHECK in GetFallbackFont
msw 2016/06/23 20:59:38 ditto nit: trailing period
Ilya Kulshin 2016/06/24 20:48:25 Done.
+ base::MessageLoopForUI message_loop;
+#endif
const FontList font_list;
// The below is 'MUSICAL SYMBOL G CLEF' (U+1D11E), which is represented in
// UTF-16 as two code units forming a surrogate pair: 0xD834 0xDD1E.
« ui/gfx/render_text_unittest.cc ('K') | « ui/gfx/render_text_unittest.cc ('k') | ui/gfx/win/dwrite_text_analysis_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698