ui/gfx/render_text_harfbuzz.cc - Issue 2054273002: Font fallback for UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2054273002: Font fallback for UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually delete old TextAnalysisSource Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index cab6fd7c9cc95748e37f37336803e8e046a8c279..6ecd15876d2471b20c480aa5473d9c961620ff94 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -1396,8 +1396,8 @@ void RenderTextHarfBuzz::ShapeRun(const base::string16& text,

Font uniscribe_font(primary_font);

msw 2016/06/23 20:59:38 nit: rename |fallback_font| or similar

Ilya Kulshin 2016/06/24 20:48:24 Done.

std::string uniscribe_family;

const base::char16* run_text = &(text[run->range.start()]);

- if (GetUniscribeFallbackFont(primary_font, run_text, run->range.length(),

- &uniscribe_font)) {

+ if (GetFallbackFont(primary_font, run_text, run->range.length(),

+ &uniscribe_font)) {

uniscribe_family = uniscribe_font.GetFontName();

if (CompareFamily(text, uniscribe_font,

uniscribe_font.GetFontRenderParams(), run,