Font fallback for UI

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
 #include "base/macros.h"
+#include "base/run_loop.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 #include "third_party/skia/include/core/SkSurface.h"
 #include "third_party/skia/include/core/SkTypeface.h"
 #include "ui/gfx/break_list.h"
@@ skipping 269 matching lines @@
   RenderTextHarfBuzz render_text_harfbuzz_;
 #if defined(OS_MACOSX)
   RenderTextMac render_text_mac_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(RenderTextAllBackends);
 };
 
 }  // namespace
 
-using RenderTextTest = testing::Test;
+class RenderTextTest : public testing::Test {
+ private:
+#if defined(OS_WIN)
+  // Needed to bypass DCHECK in GetFallbackFont

[msw, 2016/06/23 20:59:38]

nit: trailing period.

[Ilya Kulshin, 2016/06/24 20:48:25]

Done.

+  base::MessageLoopForUI message_loop_;

[msw, 2016/06/23 20:59:38]

q: can you move this to just the needed fixtures? (if there aren't many)

[Ilya Kulshin, 2016/06/24 20:48:25]

There's about two dozen tests that need this. I'll leave it as-is for now.

+#endif
+};
 
 TEST_F(RenderTextTest, DefaultStyles) {
   // Check the default styles applied to new instances and adjusted text.
   std::unique_ptr<RenderText> render_text(RenderText::CreateInstance());
   EXPECT_TRUE(render_text->text().empty());
   const wchar_t* const cases[] = { kWeak, kLtr, L"Hello", kRtl, L"", L"" };
   for (size_t i = 0; i < arraysize(cases); ++i) {
     EXPECT_TRUE(render_text->colors().EqualsValueForTesting(SK_ColorBLACK));
     EXPECT_TRUE(
         render_text->baselines().EqualsValueForTesting(NORMAL_BASELINE));
@@ skipping 3095 matching lines @@
     EXPECT_FALSE(backend.paint().isLCDRenderText());
     backend.GetHarfbuzzRunList()->runs()[0]->render_params.subpixel_rendering =
         FontRenderParams::SUBPIXEL_RENDERING_RGB;
     backend.DrawVisualText();
 #endif
     EXPECT_FALSE(backend.paint().isLCDRenderText());
   }
 }
 
 }  // namespace gfx