Font fallback for UI

ui/gfx/win/dwrite_text_analysis_source.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_COMMON_DWRITE_TEXT_ANALYSIS_SOURCE_WIN_H_
-#define CONTENT_COMMON_DWRITE_TEXT_ANALYSIS_SOURCE_WIN_H_
+#ifndef UI_GFX_WIN_DWRITE_TEXT_ANALYSIS_SOURCE_H_

[msw, 2016/06/23 20:59:38]

optional nit: rename files direct_write* to match ui/gfx/win/direct_write.*
(or rename to simply text_analysis_source.* to match the class name)

[Ilya Kulshin, 2016/06/24 20:48:24]

Done. Renamed to text_analysis_source.*

+#define UI_GFX_WIN_DWRITE_TEXT_ANALYSIS_SOURCE_H_
 
 #include <dwrite.h>
 #include <wrl.h>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
-#include "content/common/content_export.h"
+#include "ui/gfx/gfx_export.h"
 
-namespace content {
+namespace gfx {
+namespace win {
 
 // Implements an IDWriteTextAnalysisSource, describing a single pre-defined
 // chunk of text with a uniform locale, reading direction, and number
 // substitution.
-class CONTENT_EXPORT TextAnalysisSource
+class GFX_EXPORT TextAnalysisSource

[msw, 2016/06/23 20:59:38]

Can you move the applicable unit tests with this file?

[Ilya Kulshin, 2016/06/24 20:48:24]

This class doesn't have dedicated unit tests, and instead relies on being
exercised by other tests. Although now that it's no longer in content (where
those other tests live), perhaps it deserves tests of its own.

[msw, 2016/06/27 20:45:36]

Agreed; thanks for adding some!

     : public Microsoft::WRL::RuntimeClass<
           Microsoft::WRL::RuntimeClassFlags<Microsoft::WRL::ClassicCom>,
           IDWriteTextAnalysisSource> {
  public:
   TextAnalysisSource();
 
   // IDWriteTextAnalysisSource:
   HRESULT STDMETHODCALLTYPE GetLocaleName(UINT32 text_position,
                                           UINT32* text_length,
                                           const WCHAR** locale_name) override;
@@ skipping 21 matching lines @@
 
  private:
   base::string16 text_;
   base::string16 locale_name_;
   Microsoft::WRL::ComPtr<IDWriteNumberSubstitution> number_substitution_;
   DWRITE_READING_DIRECTION reading_direction_;
 
   DISALLOW_ASSIGN(TextAnalysisSource);
 };
 
-}  // namespace content
+}  // namespace win
+}  // namespace gfx
 
-#endif  // CONTENT_COMMON_DWRITE_TEXT_ANALYSIS_SOURCE_WIN_H_
+#endif  // UI_GFX_WIN_DWRITE_TEXT_ANALYSIS_SOURCE_H_