Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2054253002: Remove unused variables, cc/ edition. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused variables, cc/ edition. These were exposed while trying to make various geometry classes constexpr. BUG=none TEST=none CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c135da49a157af3fe9aadb78dae8adf480a6bb9f Cr-Commit-Position: refs/heads/master@{#399353}

Patch Set 1 #

Patch Set 2 : Revert functional changes #

Total comments: 2

Patch Set 3 : Delete perftest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -243 lines) Patch
M cc/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/surface_aggregator_test_helpers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 2 1 chunk +0 lines, -220 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Peter Kasting
Please tell me what should be done with the code in occlusiion_tracker_perftest.cc.
4 years, 6 months ago (2016-06-10 21:24:36 UTC) #3
danakj
LGTM https://codereview.chromium.org/2054253002/diff/20001/cc/trees/occlusion_tracker_perftest.cc File cc/trees/occlusion_tracker_perftest.cc (right): https://codereview.chromium.org/2054253002/diff/20001/cc/trees/occlusion_tracker_perftest.cc#newcode191 cc/trees/occlusion_tracker_perftest.cc:191: /* This block doesn't seem to do anything, ...
4 years, 6 months ago (2016-06-10 21:30:58 UTC) #4
Peter Kasting
https://codereview.chromium.org/2054253002/diff/20001/cc/trees/occlusion_tracker_perftest.cc File cc/trees/occlusion_tracker_perftest.cc (right): https://codereview.chromium.org/2054253002/diff/20001/cc/trees/occlusion_tracker_perftest.cc#newcode191 cc/trees/occlusion_tracker_perftest.cc:191: /* This block doesn't seem to do anything, missing ...
4 years, 6 months ago (2016-06-10 21:56:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054253002/40001
4 years, 6 months ago (2016-06-10 21:57:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86166)
4 years, 6 months ago (2016-06-11 01:40:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054253002/40001
4 years, 6 months ago (2016-06-11 01:41:45 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-11 02:22:29 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 02:23:53 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c135da49a157af3fe9aadb78dae8adf480a6bb9f
Cr-Commit-Position: refs/heads/master@{#399353}

Powered by Google App Engine
This is Rietveld 408576698