Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2054223002: Request an sRGB FBO0 on Android. Fixes sRGB GL mode. (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Request an sRGB FBO0 on Android. Fixes sRGB GL mode. Tried to comment my logic, but it's totally possible that we run on some device where this doesn't work. From a strict reading of the relevant specs, what I'm doing shouldn't work on the Nexus 5X, but it's necessary to get correct results. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054223002 Committed: https://skia.googlesource.com/skia/+/25d57db23445b5602d968fecf015fa8c36246e4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tools/viewer/sk_app/android/GLWindowContext_android.cpp View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054223002/1
4 years, 6 months ago (2016-06-10 20:34:50 UTC) #3
Brian Osman
4 years, 6 months ago (2016-06-10 20:34:59 UTC) #5
Brian Osman
Adding more people.
4 years, 6 months ago (2016-06-10 20:36:39 UTC) #7
bsalomon
lgtm
4 years, 6 months ago (2016-06-10 20:44:05 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 20:53:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054223002/1
4 years, 6 months ago (2016-06-13 14:36:33 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 14:49:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/25d57db23445b5602d968fecf015fa8c36246e4a

Powered by Google App Engine
This is Rietveld 408576698