third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h - Issue 2054203002: service worker: Fix the type of an update promise reject value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 2054203002: service worker: Fix the type of an update promise reject value (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: FIXME => TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/update.html ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

index ef7959d04aceb7199b0299a687bc699bbbdcbfe7..7e4701986451780b8ccb1cec9d97fdd5c5c1a2d3 100644

--- a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

+++ b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

@@ -189,6 +189,7 @@ private:

ScriptPromiseResolver* resolver = this->resolver();

if (!resolver->getExecutionContext() || resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

+ ScriptState::Scope scope(resolver->getScriptState());

resolver->reject(T::take(resolver, pass(result)));

}

};