content/browser/service_worker/service_worker_registration_status.cc - Issue 2054203002: service worker: Fix the type of an update promise reject value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_status.cc

Issue 2054203002: service worker: Fix the type of an update promise reject value (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_status.cc

diff --git a/content/browser/service_worker/service_worker_registration_status.cc b/content/browser/service_worker/service_worker_registration_status.cc

index 46ff019bd2cca58a8f23db6e6e62985bbbc5a965..e404eadda35e0693d09c992ae64ac123cedd2372 100644

--- a/content/browser/service_worker/service_worker_registration_status.cc

+++ b/content/browser/service_worker/service_worker_registration_status.cc

@@ -31,7 +31,6 @@ void GetServiceWorkerRegistrationStatusResponse(

case SERVICE_WORKER_ERROR_START_WORKER_FAILED:

case SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED:

case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:

- case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED:

case SERVICE_WORKER_ERROR_REDUNDANT:

case SERVICE_WORKER_ERROR_DISALLOWED:

*error_type = WebServiceWorkerError::ErrorTypeInstall;

@@ -45,6 +44,10 @@ void GetServiceWorkerRegistrationStatusResponse(

*error_type = WebServiceWorkerError::ErrorTypeNetwork;

return;

+ case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED:

+ *error_type = WebServiceWorkerError::ErrorTypeScriptEvaluateFailed;

+ return;

case SERVICE_WORKER_ERROR_SECURITY:

*error_type = WebServiceWorkerError::ErrorTypeSecurity;

return;